Skip to content

Conversation

@bruno-garcia
Copy link
Member

Lets see what happens

#skip-changelog

@jpnurmi
Copy link
Collaborator

jpnurmi commented May 28, 2025

@bruno-garcia it's green 😉

- "**/*DeviceTests*.csproj"
- "**/*Maui.Device.TestApp.csproj"

- outputPath: Sentry-CI-Build-Linux-arm64.slnf
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be nicer to have something like Sentry-CI-Build-Linux-only.slnf (or "no mobile" or whatever is a good name) to avoid duplicating the solution filter?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Btw, happy to do a separate follow-up later if that works...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems different then the other Linux though, no? Here we exclude Android too (not just tests)?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a copy of Sentry-CI-Build-Linux-musl.slnf. I was wondering if those two could use the same "Linux-only" filter without any Android-related projects.

@bruno-garcia bruno-garcia marked this pull request as ready for review May 28, 2025 18:54
@bruno-garcia bruno-garcia enabled auto-merge (squash) May 29, 2025 03:58
Copy link
Collaborator

@jamescrosswell jamescrosswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

key: sentry-native-Linux-${{ hashFiles('scripts/build-sentry-native.ps1') }}-${{ hashFiles('.git/modules/modules/sentry-native/HEAD') }}
fail-on-cache-miss: true

- name: Download sentry-native (Linux arm64)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if there's a way to combine all of these "Download sentry-native" steps into a single step with some variables.... maybe not in this PR but we should think about refactoring this before it gets out of hand.

Describe 'MAUI' -ForEach @(
@{ framework = "net8.0" }
) -Skip:$IsLinuxMusl {
) -Skip:($env:NO_MOBILE -eq "true") {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants