Refactor "Download sentry-native" steps in build.yml

[jamescrosswell]

I wonder if there's a way to combine all of these "Download sentry-native" steps into a single step with some variables.... maybe not in this PR but we should think about refactoring this before it gets out of hand.

Originally posted by @jamescrosswell in #3700 (comment)

[jpnurmi]

It's a bit unfortunate that actions/cache doesn't support wildcards. upload-artifact + download-artifact would support wildcards and merging, but not the "build only if changed" mechanism offered by actions/cache. I wonder if one could combine the two in some creative way... 🤔

[jamescrosswell]

Maybe I'm misunderstanding... snippet from the current code:

sentry-dotnet/.github/workflows/build.yml

Lines 109 to 123 in 935ce5b

	- name: Download sentry-native (Linux)
	if: ${{ (env.CI_PUBLISHING_BUILD == 'true') || (matrix.target == 'Linux') }}
	uses: actions/cache/restore@v4
	with:
	path: src/Sentry/Platforms/Native/sentry-native
	key: sentry-native-Linux-${{ hashFiles('scripts/build-sentry-native.ps1') }}-${{ hashFiles('.git/modules/modules/sentry-native/HEAD') }}
	fail-on-cache-miss: true
	- name: Download sentry-native (Linux arm64)
	if: ${{ (env.CI_PUBLISHING_BUILD == 'true') || (matrix.target == 'Linux-arm64') }}
	uses: actions/cache/restore@v4
	with:
	path: src/Sentry/Platforms/Native/sentry-native
	key: sentry-native-Linux-arm64-${{ hashFiles('scripts/build-sentry-native.ps1') }}-${{ hashFiles('.git/modules/modules/sentry-native/HEAD') }}
	fail-on-cache-miss: true

So the key in the actions/cache does support variable substitution. Couldn't we do something like this?

 - name: Download sentry-native
   if: ${{ (env.CI_PUBLISHING_BUILD == 'true') || (matrix.target == 'Linux-arm64') }} 
   uses: actions/cache/restore@v4 
   with: 
     path: src/Sentry/Platforms/Native/sentry-native 
-    key: sentry-native-Linux-${{ hashFiles('scripts/build-sentry-native.ps1') }}-${{ hashFiles('.git/modules/modules/sentry-native/HEAD') }} 
+    key: sentry-native-${{ matrix.target }}-${{ hashFiles('scripts/build-sentry-native.ps1') }}-${{ hashFiles('.git/modules/modules/sentry-native/HEAD') }} 
     fail-on-cache-miss: true 

For any particular matrix run, there's only one sentry native dependency to download right? This just uses the matrix target to specify the correct one.

Edit: Ah I see... not all of the items in the matrix have a target. With this PR though, the rid could be used to achieve this though right?

• ci: specify RID & .slnf in the matrix #4349

[jpnurmi]

The tricky part is that the publishing macOS build needs to download all other platforms too, and thus, cannot only use its own matrix property:

• sentry-native-win-x64-<sha1>
• sentry-native-win-arm64-<sha1>
• sentry-native-linux-x64-<sha1>
• sentry-native-linux-arm64-<sha1>
• sentry-native-linux-musl-x64-<sha1>
• sentry-native-macos-<sha1>

[jamescrosswell]

Ah, I see... dang 🤦🏻.