chore: support NativeAOT only on net8+ #2892
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| #else | ||
| IsNativeAot = false; | ||
| // This is a compile-time const so that the irrelevant code is removed during compilation. | ||
| internal const bool IsNativeAot = false; |
jamescrosswell
approved these changes
Nov 23, 2023
Collaborator
jamescrosswell
left a comment
jamescrosswell
left a comment
There was a problem hiding this comment.
Looks all good, presuming all the tests pass 👍🏻
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows up on #2889 getting rid of all the conditions to enable partial support of NativeAOT on net7. The support hasn't been out other than on a pre-release and .net7 is not an LTS release and it's unlikely many projects would choose to keep using it with NativeAOT now that net8 is out and improves it greatly. Also see discussions on #2886
#skip-changelog