Skip to content

Conversation

@jamescrosswell
Copy link
Collaborator

@jamescrosswell jamescrosswell commented Nov 22, 2023

#skip-changelog

Resolves #2886

No Changelog required as this is already consistent with our description for AOT support in the Changelog.

@jamescrosswell jamescrosswell changed the base branch from main to feat/4.0.0 November 22, 2023 23:18
@jamescrosswell jamescrosswell marked this pull request as ready for review November 22, 2023 23:25
@jamescrosswell jamescrosswell marked this pull request as draft November 22, 2023 23:26
@jamescrosswell jamescrosswell marked this pull request as ready for review November 23, 2023 01:28
@jamescrosswell jamescrosswell merged commit 464fd4c into feat/4.0.0 Nov 23, 2023
@jamescrosswell jamescrosswell deleted the aot_net8_and_above branch November 23, 2023 01:29
Copy link
Collaborator

@vaind vaind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx. I'll update NativeAOT conditions

<!-- Only compile with IsAotCompatible on .NET 6.0 and later. Our Device Tests fail for net7.0-android with this enabled as well -->
<PropertyGroup Condition="'$(TargetFramework)' != 'net7.0-android' AND $([System.Text.RegularExpressions.Regex]::IsMatch('$(TargetFramework)', '^(?!net5\.|net4\d{2}|netstandard)net\d+'))">
<!-- Only compile with IsAotCompatible on .NET 8.0 and later -->
<PropertyGroup Condition="$([System.Text.RegularExpressions.Regex]::IsMatch('$(TargetFramework)', 'net8\.|net9\.|net\d{2,}\.'))">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

net9 and netXY? Aren't we getting ahead of ourselves? 😆

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah probably... I was trying to write it so it wouldn't need to be changed next year when net9.0 is released... and then I added another 30 years or so runway after that (vast overkill) 😛 In reality, we're probably going to have to change it in a week or two when we discover it doesn't work with net8.0-android or something.

@jamescrosswell
Copy link
Collaborator Author

Thx. I'll update NativeAOT conditions

Yeah you can see I removed '$(TargetFramework)' != 'net7.0-android' from the Condition... work works at the moment because the bindings projects aren't targeting net8.0 but I'm not sure if the Device Tests will all pass on Android with AOT enabled, once we bump these to net8.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

FrameworkSupportsAot should only be set for .net8 and higher

4 participants