-
-
Notifications
You must be signed in to change notification settings - Fork 226
Only set FrameworkSupportsAot for net8.0+ #2889
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
vaind
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx. I'll update NativeAOT conditions
| <!-- Only compile with IsAotCompatible on .NET 6.0 and later. Our Device Tests fail for net7.0-android with this enabled as well --> | ||
| <PropertyGroup Condition="'$(TargetFramework)' != 'net7.0-android' AND $([System.Text.RegularExpressions.Regex]::IsMatch('$(TargetFramework)', '^(?!net5\.|net4\d{2}|netstandard)net\d+'))"> | ||
| <!-- Only compile with IsAotCompatible on .NET 8.0 and later --> | ||
| <PropertyGroup Condition="$([System.Text.RegularExpressions.Regex]::IsMatch('$(TargetFramework)', 'net8\.|net9\.|net\d{2,}\.'))"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
net9 and netXY? Aren't we getting ahead of ourselves? 😆
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah probably... I was trying to write it so it wouldn't need to be changed next year when net9.0 is released... and then I added another 30 years or so runway after that (vast overkill) 😛 In reality, we're probably going to have to change it in a week or two when we discover it doesn't work with net8.0-android or something.
Yeah you can see I removed |
#skip-changelog
Resolves #2886
No Changelog required as this is already consistent with our description for AOT support in the Changelog.