Skip to content

fix: aspnetcore dependency #2873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 21, 2023
Merged

fix: aspnetcore dependency #2873

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
89301cb
fix: aspnet core dep version
bruno-garcia Nov 21, 2023
a70360f
removed commented dependency
bitsandfoxes Nov 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/Sentry.AspNetCore/Sentry.AspNetCore.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,13 @@

<ItemGroup Condition="'$(TargetFramework)' != 'netstandard2.0'">
<FrameworkReference Include="Microsoft.AspNetCore.App" />
</ItemGroup>

<!-- <ItemGroup Condition="'$(TargetFramework)' == 'net6.0'">
<PackageReference Include="Microsoft.Extensions.Configuration.Binder" Version="6.0.0" />
</ItemGroup> -->

Copy link
Member Author

@bruno-garcia bruno-garcia Nov 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If CI works without this, just delete it:

Suggested change
<!-- <ItemGroup Condition="'$(TargetFramework)' == 'net6.0'">
<PackageReference Include="Microsoft.Extensions.Configuration.Binder" Version="6.0.0" />
</ItemGroup> -->
<!-- <ItemGroup Condition="'$(TargetFramework)' == 'net6.0'">
<PackageReference Include="Microsoft.Extensions.Configuration.Binder" Version="6.0.0" />
</ItemGroup> -->

Copy link
Collaborator

@jamescrosswell jamescrosswell Nov 21, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, very mysterious. I am wondering how this code can possibly work in CI without that, as it depends on the source generated configuration bindings from Microsoft.Extensions.Configuration.Binder:

sentry-dotnet/src/Sentry.AspNetCore/SentryAspNetCoreOptionsSetup.cs

Line 70 in 89301cb

_config.Bind(bindable);

They are only used at design time to generate the *.g.cs classes I guess... still doesn't make sense to me though.

Copy link
Member Author

@bruno-garcia bruno-garcia Nov 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.NET 6 prob used reflection, and .NET 8 added source generator (get make this trimmable/AOT friendly)

Copy link
Collaborator

@jamescrosswell jamescrosswell Nov 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That particular method (Bind) isnt' available via reflection (it's a generated method) and the codepath that uses it is when !NETSTANDARD2_0 so it still doesn't compute for me 🤷🏻‍♂️

<ItemGroup Condition="'$(TargetFramework)' == 'net8.0'">
<PackageReference Include="Microsoft.Extensions.Configuration.Binder" Version="8.0.0" />
</ItemGroup>

Expand Down