-
-
Notifications
You must be signed in to change notification settings - Fork 226
fix: aspnetcore dependency #2873
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| <!-- <ItemGroup Condition="'$(TargetFramework)' == 'net6.0'"> | ||
| <PackageReference Include="Microsoft.Extensions.Configuration.Binder" Version="6.0.0" /> | ||
| </ItemGroup> --> | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If CI works without this, just delete it:
| <!-- <ItemGroup Condition="'$(TargetFramework)' == 'net6.0'"> | |
| <PackageReference Include="Microsoft.Extensions.Configuration.Binder" Version="6.0.0" /> | |
| </ItemGroup> --> | |
| <!-- <ItemGroup Condition="'$(TargetFramework)' == 'net6.0'"> | |
| <PackageReference Include="Microsoft.Extensions.Configuration.Binder" Version="6.0.0" /> | |
| </ItemGroup> --> | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, very mysterious. I am wondering how this code can possibly work in CI without that, as it depends on the source generated configuration bindings from Microsoft.Extensions.Configuration.Binder:
| _config.Bind(bindable); |
They are only used at design time to generate the *.g.cs classes I guess... still doesn't make sense to me though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.NET 6 prob used reflection, and .NET 8 added source generator (get make this trimmable/AOT friendly)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That particular method (Bind) isnt' available via reflection (it's a generated method) and the codepath that uses it is when !NETSTANDARD2_0 so it still doesn't compute for me 🤷🏻♂️
On
mainwe don't have any dependencies, so this was introduced on net8.0:sentry-dotnet/src/Sentry.AspNetCore/Sentry.AspNetCore.csproj
Line 28 in 4d239a5
If that's the case, we don't need to add when running on net6.0/7.0.
If not, we should define the lowest version per TFM
#skip-changelog