Skip to content

Conversation

@bitsandfoxes
Copy link
Contributor

First iteration

OLD:
|                  Method | SpanCount |        Mean |        Error |    StdDev |     Gen0 |     Gen1 |  Allocated |
|------------------------ |---------- |------------:|-------------:|----------:|---------:|---------:|-----------:|
| 'Creates a Transaction' |         1 |    18.74 us |     9.389 us |  0.515 us |   1.9531 |   0.7324 |   11.45 KB |
| 'Creates a Transaction' |        10 |    46.50 us |    10.036 us |  0.550 us |   5.1270 |   1.8921 |   29.41 KB |
| 'Creates a Transaction' |       100 |   328.92 us |   391.109 us | 21.438 us |  36.6211 |  13.1836 |  209.87 KB |
| 'Creates a Transaction' |      1000 | 3,126.71 us | 1,627.935 us | 89.233 us | 343.7500 | 121.0938 | 2010.25 KB |

NEW:
|                  Method | SpanCount |        Mean |        Error |     StdDev |     Gen0 |    Gen1 |  Allocated |
|------------------------ |---------- |------------:|-------------:|-----------:|---------:|--------:|-----------:|
| 'Creates a Transaction' |         1 |    16.71 us |     5.680 us |   0.311 us |   2.9907 |  0.9766 |   10.64 KB |
| 'Creates a Transaction' |        10 |    40.69 us |    49.539 us |   2.715 us |   3.7231 |  1.4038 |   21.28 KB |
| 'Creates a Transaction' |       100 |   233.04 us |   140.121 us |   7.680 us |  28.3203 |  8.7891 |  128.62 KB |
| 'Creates a Transaction' |      1000 | 2,260.93 us | 2,510.363 us | 137.601 us | 253.9063 | 82.0313 | 1197.68 KB |

@github-actions
Copy link
Contributor

github-actions bot commented Sep 15, 2023

Fails
🚫 Please consider adding a changelog entry for the next release.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

- SDK internal Tag handling ([#2621](https://github.com/getsentry/sentry-dotnet/pull/2621))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 🚫 dangerJS against b4a8ce6

/// </summary>
/// <param name="hasTags"></param>
/// <returns></returns>
public static IReadOnlyDictionary<string, string>? GetTagsOrNull(this IHasTags hasTags)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this method now that we have InternalTags again?

Suggested change
public static IReadOnlyDictionary<string, string>? GetTagsOrNull(this IHasTags hasTags)
internal static IReadOnlyDictionary<string, string>? GetTagsOrNull(this IHasTags hasTags)

@bitsandfoxes
Copy link
Contributor Author

Superseded by #2636

@bitsandfoxes bitsandfoxes deleted the fix/span-tags branch September 19, 2023 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants