Construct hint items lazily #2632
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bitsandfoxes
approved these changes
Sep 19, 2023
vaind
pushed a commit
that referenced
this pull request
Sep 27, 2023
This was referenced Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#skip-changelog
Related to #2607 (comment)
In applications that use breadcrumbs heavily, the biggest memory hog is
Dictionary<string,object?>. The following is a snapshot from a memory profile of an app that's creating lots of breadcrumbs:Most of those are unnecessarily created by the Hint constructor. By delaying instatiation of
Hint.Itemsuntil they're actually used, we can avoid most allocations.Results
Saves about (752B - 672B) / 752B = 10.64% of memory allocated for breadcrumbs.
Note: The savings scale linearly from individual breadcrumbs to hundreds of breadcrumbs (although savings for breadcrumbs in particular will be capped per Transaction by
SentryOptions.MaxBreadcrumbs.Before
After