Skip to content

Conversation

@philipphofmann
Copy link
Member

@philipphofmann philipphofmann commented Nov 10, 2025

Reverts #6518, because the SwiftLogTests are failing to compile with https://github.com/getsentry/sentry-cocoa/actions/runs/19169734508/job/54798972584. It's not a trivial fix, so let's revert and fix it to have main green gain.

#skip-changelog

@philipphofmann philipphofmann added the ready-to-merge Use this label to trigger all PR workflows label Nov 10, 2025
@philipphofmann philipphofmann enabled auto-merge (squash) November 10, 2025 09:26
@codecov
Copy link

codecov bot commented Nov 10, 2025

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
3954 1 3953 55
View the top 1 failed test(s) by shortest run time
iOS_Swift_UITests.UserFeedbackUITests::testCancelFromFormByButton
Stack Traces | 0s run time
.../iOS-Swift/iOS-Swift-UITests/UserFeedbackUITests.swift:613 - XCTAssertTrue failed - Expected file to exist at .../69FB61CA-A7A6-4F48-8F3B-A71CB880A6FF/Library/Application Support/io.sentry/feedback/onFormClose

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@github-actions
Copy link
Contributor

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1228.64 ms 1263.09 ms 34.45 ms
Size 24.15 KiB 1023.18 KiB 999.03 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
854ca12 1219.94 ms 1251.32 ms 31.38 ms
a6f5396 1211.81 ms 1245.63 ms 33.82 ms
d637379 1226.43 ms 1250.77 ms 24.34 ms
4a7a005 1229.15 ms 1243.35 ms 14.20 ms
d48a247 1243.59 ms 1273.27 ms 29.67 ms
079bcc8 1217.88 ms 1234.88 ms 17.00 ms
1fecbb8 1242.78 ms 1265.40 ms 22.62 ms
acac774 1217.76 ms 1253.29 ms 35.52 ms
2a6f451 1212.89 ms 1237.45 ms 24.56 ms
75b23cd 1227.10 ms 1253.61 ms 26.51 ms

App size

Revision Plain With Sentry Diff
854ca12 23.74 KiB 996.96 KiB 973.22 KiB
a6f5396 23.75 KiB 989.12 KiB 965.38 KiB
d637379 23.75 KiB 855.38 KiB 831.63 KiB
4a7a005 23.75 KiB 979.96 KiB 956.22 KiB
d48a247 23.75 KiB 994.73 KiB 970.99 KiB
079bcc8 23.74 KiB 874.07 KiB 850.33 KiB
1fecbb8 23.75 KiB 969.28 KiB 945.53 KiB
acac774 23.75 KiB 866.51 KiB 842.76 KiB
2a6f451 23.75 KiB 913.13 KiB 889.38 KiB
75b23cd 23.75 KiB 933.66 KiB 909.92 KiB

@philipphofmann philipphofmann merged commit 2699f74 into main Nov 10, 2025
281 of 305 checks passed
@philipphofmann philipphofmann deleted the revert-6518-denrase/logs-in-hub-and-client branch November 10, 2025 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge Use this label to trigger all PR workflows

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants