-
-
Notifications
You must be signed in to change notification settings - Fork 372
Structured Logs: Add log APIs to Hub and Client
#6518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@philipphofmann Hacked this together. Works locally. If there are no other blockers, everything should work out without breaking existing public API. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #6518 +/- ##
=============================================
- Coverage 85.163% 84.729% -0.435%
=============================================
Files 453 447 -6
Lines 27689 27379 -310
Branches 12111 11971 -140
=============================================
- Hits 23581 23198 -383
- Misses 4063 4134 +71
- Partials 45 47 +2
... and 72 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
captureLog to Hub and Client
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| d1c4916 | 1216.66 ms | 1244.73 ms | 28.08 ms |
| d1c0538 | 1227.49 ms | 1246.96 ms | 19.47 ms |
| cc02c0d | 1234.69 ms | 1247.15 ms | 12.46 ms |
| 23b6a91 | 1227.73 ms | 1262.93 ms | 35.20 ms |
| ea2e54c | 1207.78 ms | 1218.13 ms | 10.35 ms |
| 6c0b61e | 1194.21 ms | 1218.74 ms | 24.53 ms |
| 83d27f6 | 1233.56 ms | 1259.24 ms | 25.68 ms |
| 1a34ddc | 1217.79 ms | 1242.17 ms | 24.38 ms |
| d05d866 | 1211.78 ms | 1230.96 ms | 19.18 ms |
| bc0a04c | 1226.83 ms | 1255.04 ms | 28.21 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| d1c4916 | 23.75 KiB | 981.31 KiB | 957.56 KiB |
| d1c0538 | 23.75 KiB | 928.87 KiB | 905.12 KiB |
| cc02c0d | 23.75 KiB | 912.37 KiB | 888.62 KiB |
| 23b6a91 | 23.75 KiB | 1004.80 KiB | 981.06 KiB |
| ea2e54c | 23.75 KiB | 919.70 KiB | 895.95 KiB |
| 6c0b61e | 23.75 KiB | 1.02 MiB | 1019.10 KiB |
| 83d27f6 | 23.75 KiB | 928.88 KiB | 905.13 KiB |
| 1a34ddc | 23.75 KiB | 919.90 KiB | 896.15 KiB |
| d05d866 | 23.75 KiB | 878.60 KiB | 854.85 KiB |
| bc0a04c | 23.75 KiB | 933.32 KiB | 909.57 KiB |
Previous results on branch: denrase/logs-in-hub-and-client
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| db59d5d | 1217.41 ms | 1240.59 ms | 23.18 ms |
| 31d864b | 1212.77 ms | 1246.85 ms | 34.08 ms |
| 391bd71 | 1231.72 ms | 1262.83 ms | 31.11 ms |
| 90fcb79 | 1220.14 ms | 1258.02 ms | 37.88 ms |
| cf93b3b | 1224.50 ms | 1246.35 ms | 21.85 ms |
| 225f528 | 1211.81 ms | 1252.58 ms | 40.77 ms |
| a429649 | 1216.39 ms | 1217.77 ms | 1.39 ms |
| 08821c7 | 1206.15 ms | 1239.35 ms | 33.20 ms |
| 9df70d3 | 1228.40 ms | 1262.55 ms | 34.16 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| db59d5d | 23.75 KiB | 1.01 MiB | 1006.79 KiB |
| 31d864b | 23.75 KiB | 1.00 MiB | 1003.12 KiB |
| 391bd71 | 23.75 KiB | 1.00 MiB | 1004.71 KiB |
| 90fcb79 | 23.75 KiB | 1.00 MiB | 1002.61 KiB |
| cf93b3b | 23.75 KiB | 1.00 MiB | 1003.12 KiB |
| 225f528 | 23.75 KiB | 1.01 MiB | 1006.79 KiB |
| a429649 | 23.75 KiB | 1.00 MiB | 1002.92 KiB |
| 08821c7 | 23.75 KiB | 1.02 MiB | 1017.66 KiB |
| 9df70d3 | 23.75 KiB | 1.01 MiB | 1006.51 KiB |
…/sentry-cocoa into denrase/logs-in-hub-and-client
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, when ditching the force cast #6518 (comment). Thanks @denrase
# Conflicts: # Sentry.xcodeproj/project.pbxproj
philipphofmann
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two more comments. Thanks
📜 Description
capture(log:scope:)methods toClientloggerAPI toHubSentryLog, so users can actually create them for hub/client method usage.💡 Motivation and Context
Closes #6503
💚 How did you test it?
Unit tests
📝 Checklist
You have to check all boxes before merging:
sendDefaultPIIis enabled.