-
-
Notifications
You must be signed in to change notification settings - Fork 8
updater: support cmake FetchContent with enhanced robustness #92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
- support cmake FetchContent with enhanced robustness ([#92](https://github.com/getsentry/github-workflows/pull/92))If none of the above apply, you can opt out of this check by adding |
Co-authored-by: vaind <[email protected]>
Co-authored-by: vaind <[email protected]>
Copilot
AI
changed the title
[WIP] updater: support cmake FetchContent
updater: support cmake FetchContent
Jul 31, 2025
Copilot finished work on behalf of
vaind
July 31, 2025 14:46
Collaborator
|
@sentry review |
Collaborator
|
@copilot address review comments from @seer-by-sentry |
…IT_TAG values Co-authored-by: vaind <[email protected]>
Copilot
AI
changed the title
updater: support cmake FetchContent
updater: support cmake FetchContent with enhanced robustness
Jul 31, 2025
Copilot finished work on behalf of
vaind
July 31, 2025 16:27
Collaborator
|
replaced by #104 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for updating CMake dependencies that use
FetchContent_Declaresyntax to the dependency updater system with enhanced robustness and performance optimizations.The updater can now automatically parse and update CMake files containing:
FetchContent_Declare( sentry-native GIT_REPOSITORY https://github.com/getsentry/sentry-native GIT_TAG a64d5bd8ee130f2cda196b6fa7d9b65bfa6d32e2 # 0.9.1 GIT_SHALLOW FALSE GIT_SUBMODULES "external/breakpad" )Features
.cmakefiles,CMakeLists.txt, or any file containingFetchContent_DeclareGIT_REPOSITORYto determine the dependency sourceGIT_TAG(supports both semantic versions and commit hashes)"v1.0.0") and unquoted (v1.0.0) GIT_TAG values while preserving original formatUsage
Add to your workflow:
The implementation is fully backward compatible with existing dependency types (submodules, properties files, scripts) and includes comprehensive test coverage including edge cases for quoted values.
Fixes #91.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.