Address review comments: optimize CMake detection and handle quoted GIT_TAG values

Co-authored-by: vaind <[email protected]>

Author: Copilot

updater/scripts/update-dependency.ps1

@@ -40,7 +40,7 @@ function SetOutput([string] $name, $value)
 if (-not $isSubmodule)
 {
     $isScript = $Path -match '\.(ps1|sh)$'
-    $isCMake = $Path -match '\.(cmake|txt)$' -or ((Test-Path $Path -PathType Leaf) -and ((Get-Content $Path -Raw -ErrorAction SilentlyContinue) -match 'FetchContent_Declare'))
+    $isCMake = $Path -match '\.(cmake|txt)$' -or ((Test-Path $Path -PathType Leaf) -and $Path -notmatch '\.(ps1|sh)$' -and ((Get-Content $Path -Raw -ErrorAction SilentlyContinue) -match 'FetchContent_Declare'))
     function DependencyConfig ([Parameter(Mandatory = $true)][string] $action, [string] $value = $null)
     {
         if ($isScript)
@@ -76,9 +76,13 @@ if (-not $isSubmodule)
                 'get-version'
                 {
                     $content = Get-Content $Path -Raw
-                    if ($content -match '(?m)^\s*GIT_TAG\s+([^\s#]+)')
+                    if ($content -match '(?m)^\s*GIT_TAG\s+(?:"([^"]+)"|([^\s#]+))')
                     {
-                        return $Matches[1]
+                        if ($Matches[1]) { 
+                            return $Matches[1] 
+                        } else { 
+                            return $Matches[2] 
+                        }
                     }
                     throw "Could not find GIT_TAG in CMake file $Path"
                 }
@@ -97,9 +101,17 @@ if (-not $isSubmodule)
                     $updated = $false
                     for ($i = 0; $i -lt $content.Length; $i++)
                     {
-                        if ($content[$i] -match '^(\s*GIT_TAG\s+)[^\s#]+(.*)$')
+                        if ($content[$i] -match '^(\s*GIT_TAG\s+)(")([^"]+)(".*)$')
+                        {
+                            # Quoted version - preserve quotes
+                            $content[$i] = $Matches[1] + $Matches[2] + $value + $Matches[4]
+                            $updated = $true
+                            break
+                        }
+                        elseif ($content[$i] -match '^(\s*GIT_TAG\s+)([^\s#]+)(.*)$')
                         {
-                            $content[$i] = $Matches[1] + $value + $Matches[2]
+                            # Unquoted version
+                            $content[$i] = $Matches[1] + $value + $Matches[3]
                             $updated = $true
                             break
                         }

updater/tests/update-dependency.Tests.ps1

@@ -346,5 +346,19 @@ switch ($action)
             $content = Get-Content $testFile
             $content[4] | Should -Match "GIT_TAG $currentVersion"
         }
+
+        It 'handles quoted GIT_TAG values' {
+            $testFile = "$testDir/test.cmake"
+            @(
+                'FetchContent_Declare(',
+                '    dependency',
+                "    GIT_REPOSITORY $repoUrl",
+                '    GIT_TAG "v0.0.1"',
+                ')'
+            ) | Out-File $testFile
+            UpdateDependency $testFile
+            $content = Get-Content $testFile
+            $content[3] | Should -Match "GIT_TAG `"$currentVersion`""
+        }
     }
 }