Skip to content

Conversation

@chapulina
Copy link
Contributor

🎈 Release

The pre-release testing with #1650 went well, we only uncovered one trivial bug, solved in gazebosim/gz-gui#472

Checklist

  • Asked team if this is a good time for a release
  • There are no changes to be ported from the previous major version
  • No PRs targeted at this major version are close to getting in
  • Bumped minor for new features, patch for bug fixes
  • Updated changelog
  • Updated migration guide (as needed)
  • ~~Link to PR updating dependency versions in appropriate repository in ignition-release (as needed): ~~

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Louise Poubel <[email protected]>
@chapulina chapulina requested a review from mjcarroll as a code owner August 17, 2022 18:28
@chapulina chapulina merged commit 873b43b into ign-gazebo3 Aug 17, 2022
@chapulina chapulina deleted the chapulina/3.14.0 branch August 17, 2022 19:42
@chapulina chapulina added the 🏰 citadel Ignition Citadel label Aug 17, 2022
nkoenig added a commit that referenced this pull request Nov 3, 2022
* 🎈 3.14.0~pre1 (#1650)

Signed-off-by: Louise Poubel <[email protected]>

* Remove redundant namespace references (#1635)

Signed-off-by: methylDragon <[email protected]>

* 🎈 3.14.0 (#1657)

Signed-off-by: Louise Poubel <[email protected]>

Signed-off-by: Louise Poubel <[email protected]>

* readd namespaces for Q_ARGS (#1670)

* Remove actors from screen when they are supposed to (#1699)

# 🦟 Bug fix

Supercedes #1697.  Note: When forward porting we will have to update the hashmaps to erase the new hashmaps created.

Fixes #<NUMBER>

## Summary
Found that when actors are De-spawned the actor visuals are not destroyed. This commit addresses this bug by adding the missing remove logic in RenderUtils.

## Before
![bug](https://user-images.githubusercontent.com/542272/189558600-196d98c5-1dcf-4d6c-93d6-7493df38c0e4.gif)

## After
![no_bug](https://user-images.githubusercontent.com/542272/189558924-3f2e3c5d-68f3-4d80-aee4-3dc3ce6742a1.gif)

## Notes:
Theres a lot of hashmaps being populated in RenderUtils whenever a new actor is spawned. I hope I've caught them all. 
Also while I need these working in garden (as all the projects Im working on use garden), should I backport these changes?

Signed-off-by: Arjo Chakravarty <[email protected]>

* Update examples to use gazebosim.org

Signed-off-by: Nate Koenig <[email protected]>

* Citadel: Removed warnings (#1753)

Signed-off-by: ahcorde <[email protected]>

* Added collection name to About Dialog (#1756)

Signed-off-by: ahcorde <[email protected]>

* Convert ignitionrobotics to gazebosim in tests directory (#1757)

* Convert ignitionrobotics to gaazebosim in tests directory

Signed-off-by: Nate Koenig <[email protected]>

* fix gz-gazebo

Signed-off-by: Nate Koenig <[email protected]>

Signed-off-by: Nate Koenig <[email protected]>
Co-authored-by: Nate Koenig <[email protected]>

* Convert ignitionrobotics to gazebosim in sources and includes (#1758)

Signed-off-by: Nate Koenig <[email protected]>

Signed-off-by: Nate Koenig <[email protected]>
Co-authored-by: Nate Koenig <[email protected]>

* Convert ignitionrobotics to gazebosim in tutorials (#1759)

Signed-off-by: Nate Koenig <[email protected]>

Signed-off-by: Nate Koenig <[email protected]>
Co-authored-by: Nate Koenig <[email protected]>

* Final update of ignitionrobotics to gazebosim for citadel (#1760)

Signed-off-by: Nate Koenig <[email protected]>

Signed-off-by: Nate Koenig <[email protected]>
Co-authored-by: Nate Koenig <[email protected]>

* remove PlotIcon (#1658)

Signed-off-by: youhy <[email protected]>

Signed-off-by: youhy <[email protected]>

* Fix UNIT_ign_TEST

Signed-off-by: Nate Koenig <[email protected]>

Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: methylDragon <[email protected]>
Signed-off-by: Arjo Chakravarty <[email protected]>
Signed-off-by: Nate Koenig <[email protected]>
Signed-off-by: ahcorde <[email protected]>
Signed-off-by: youhy <[email protected]>
Co-authored-by: Louise Poubel <[email protected]>
Co-authored-by: methylDragon <[email protected]>
Co-authored-by: Jenn Nguyen <[email protected]>
Co-authored-by: Arjo Chakravarty <[email protected]>
Co-authored-by: Nate Koenig <[email protected]>
Co-authored-by: Alejandro Hernández Cordero <[email protected]>
Co-authored-by: AzulRadio <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏰 citadel Ignition Citadel

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants