ign -> gz : Remove redundant namespace references #1635
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
methylDragon
force-pushed
the
namespace_cleanup
branch
from
d31a6d7 to
06a4bf0
Compare
methylDragon
force-pushed
the
namespace_cleanup
branch
5 times, most recently
from
ace58d6 to
355b08b
Compare
chapulina
suggested changes
Aug 10, 2022
methylDragon
force-pushed
the
namespace_cleanup
branch
from
355b08b to
5529d93
Compare
azeey
reviewed
Aug 10, 2022
Codecov Report
@@ Coverage Diff @@
## ign-gazebo3 #1635 +/- ##
===============================================
+ Coverage 77.94% 77.98% +0.03%
===============================================
Files 255 255
Lines 15041 15041
===============================================
+ Hits 11724 11730 +6
+ Misses 3317 3311 -6
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: methylDragon <[email protected]>
methylDragon
force-pushed
the
namespace_cleanup
branch
from
5529d93 to
2f3afcb
Compare
Contributor
Author
|
Seems this is good to go too! |
chapulina
approved these changes
Aug 17, 2022
nkoenig
added a commit
that referenced
this pull request
Nov 3, 2022
* 🎈 3.14.0~pre1 (#1650) Signed-off-by: Louise Poubel <[email protected]> * Remove redundant namespace references (#1635) Signed-off-by: methylDragon <[email protected]> * 🎈 3.14.0 (#1657) Signed-off-by: Louise Poubel <[email protected]> Signed-off-by: Louise Poubel <[email protected]> * readd namespaces for Q_ARGS (#1670) * Remove actors from screen when they are supposed to (#1699) # 🦟 Bug fix Supercedes #1697. Note: When forward porting we will have to update the hashmaps to erase the new hashmaps created. Fixes #<NUMBER> ## Summary Found that when actors are De-spawned the actor visuals are not destroyed. This commit addresses this bug by adding the missing remove logic in RenderUtils. ## Before  ## After  ## Notes: Theres a lot of hashmaps being populated in RenderUtils whenever a new actor is spawned. I hope I've caught them all. Also while I need these working in garden (as all the projects Im working on use garden), should I backport these changes? Signed-off-by: Arjo Chakravarty <[email protected]> * Update examples to use gazebosim.org Signed-off-by: Nate Koenig <[email protected]> * Citadel: Removed warnings (#1753) Signed-off-by: ahcorde <[email protected]> * Added collection name to About Dialog (#1756) Signed-off-by: ahcorde <[email protected]> * Convert ignitionrobotics to gazebosim in tests directory (#1757) * Convert ignitionrobotics to gaazebosim in tests directory Signed-off-by: Nate Koenig <[email protected]> * fix gz-gazebo Signed-off-by: Nate Koenig <[email protected]> Signed-off-by: Nate Koenig <[email protected]> Co-authored-by: Nate Koenig <[email protected]> * Convert ignitionrobotics to gazebosim in sources and includes (#1758) Signed-off-by: Nate Koenig <[email protected]> Signed-off-by: Nate Koenig <[email protected]> Co-authored-by: Nate Koenig <[email protected]> * Convert ignitionrobotics to gazebosim in tutorials (#1759) Signed-off-by: Nate Koenig <[email protected]> Signed-off-by: Nate Koenig <[email protected]> Co-authored-by: Nate Koenig <[email protected]> * Final update of ignitionrobotics to gazebosim for citadel (#1760) Signed-off-by: Nate Koenig <[email protected]> Signed-off-by: Nate Koenig <[email protected]> Co-authored-by: Nate Koenig <[email protected]> * remove PlotIcon (#1658) Signed-off-by: youhy <[email protected]> Signed-off-by: youhy <[email protected]> * Fix UNIT_ign_TEST Signed-off-by: Nate Koenig <[email protected]> Signed-off-by: Louise Poubel <[email protected]> Signed-off-by: methylDragon <[email protected]> Signed-off-by: Arjo Chakravarty <[email protected]> Signed-off-by: Nate Koenig <[email protected]> Signed-off-by: ahcorde <[email protected]> Signed-off-by: youhy <[email protected]> Co-authored-by: Louise Poubel <[email protected]> Co-authored-by: methylDragon <[email protected]> Co-authored-by: Jenn Nguyen <[email protected]> Co-authored-by: Arjo Chakravarty <[email protected]> Co-authored-by: Nate Koenig <[email protected]> Co-authored-by: Alejandro Hernández Cordero <[email protected]> Co-authored-by: AzulRadio <[email protected]>
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of: gazebo-tooling/release-tools#784