Skip to content

Conversation

@cosmo0920
Copy link
Contributor

@cosmo0920 cosmo0920 commented Nov 15, 2025

Set up as make_latest: false is needed for 4.1 branch on releasing workflow.


Enter [N/A] in the box, if an item is not applicable to your change.

Testing
Before we can approve your change; please submit the following in a comment:

  • Example configuration file for the change
  • Debug log output from testing the change
  • Attached Valgrind output that shows no leaks or memory corruption was found

If this is a change to packaging of containers or native binaries then please confirm it works for all targets.

  • Run local packaging test showing all targets (including any new ones) build.
  • Set ok-package-test label to test for all targets (requires maintainer to do).

Documentation

  • Documentation required for this feature

Backporting

  • Backport to latest stable release.

Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.

Summary by CodeRabbit

  • Chores
    • Updated release configuration to ensure version 4.1 is not designated as the latest release.

@coderabbitai
Copy link

coderabbitai bot commented Nov 15, 2025

Walkthrough

Modified the staging release workflow to set make_latest to false for the 4.1 release, removing its designation as the latest release and aligning it with other non-latest release branches.

Changes

Cohort / File(s) Summary
Release configuration
\.github/workflows/staging-release\.yaml
Set make_latest parameter to false for 4.1 release to prevent marking as latest

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

  • Single parameter modification in a YAML workflow file with clear intent

Possibly related PRs

Suggested labels

docs-required

Suggested reviewers

  • niedbalski
  • patrick-stephens
  • celalettin1286

Poem

🐰 A flag set to false, oh what a sight,
Four-point-one steps back from the spotlight,
The latest crown rests on four-point-two's head,
Versioning logic, so clearly read! ✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main change: preventing 4.1 releases from being marked as latest on GitHub Releases, which aligns with the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch cosmo0920-make-4.1-is-not-latest

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f1ba23a and 46a3d60.

📒 Files selected for processing (1)
  • .github/workflows/staging-release.yaml (1 hunks)
🔇 Additional comments (1)
.github/workflows/staging-release.yaml (1)

845-854: Verify intent: is target_commitish intentionally omitted for the 4.1 release?

The 4.1 release step is missing the target_commitish field, whereas all earlier release versions (2.0 through 3.2) explicitly specify it (e.g., target_commitish: '2.0'). The 4.2 section also lacks this field.

This could indicate:

  1. Intentional design for the 4.x series (perhaps handled differently), or
  2. An oversight that should be corrected for consistency

If releases from the 4.1 branch should be tagged from the 4.1 ref (not the default), please add target_commitish: '4.1' to match the pattern of earlier versions.

The make_latest: false assignment on line 854 correctly implements the PR objective—ensuring 4.1 releases are not marked as "latest" on GitHub Releases.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants