workflows: staging-release: add v4.2 #11153
Conversation
Signed-off-by: Eduardo Silva <[email protected]>
edsiper
requested review from
celalettin1286,
niedbalski and
patrick-stephens
as code owners
|
Caution Review failedThe pull request is closed. WalkthroughThe GitHub Actions staging-release workflow is updated to designate version 4.2 as the latest release, replacing version 4.1. Changes are applied consistently across release creation, documentation generation, and version update job sections within the same workflow file. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| tag_name: v${{ inputs.version }} | ||
| make_latest: true |
There was a problem hiding this comment.
The step renamed to "Release 4.1 - not latest" still passes make_latest: true to softprops/action-gh-release. When a 4.1.x patch is published after 4.2 exists, GitHub will flip the latest release pointer back to 4.1.x, hiding the actual current 4.2 release and confusing downstream automation that relies on the latest tag. This flag should be false like the other non‑latest series.
Useful? React with 👍 / 👎.
| - name: Release 4.1 - not latest | ||
| if: startsWith(inputs.version, '4.1') | ||
| uses: actions/checkout@v5 | ||
| with: | ||
| repository: fluent/fluent-bit-docs | ||
| token: ${{ secrets.GH_PA_TOKEN }} |
There was a problem hiding this comment.
In the docs PR job the new "Release 4.1 - not latest" block still checks out the default branch (no ref), whereas all other non‑latest series checkout their version branches. After 4.2 becomes latest, running the workflow for a 4.1.x patch will push documentation changes to the master/latest branch instead of the 4.1 branch, overwriting current docs. This step should specify ref: 4.1 similar to the preceding entries.
Useful? React with 👍 / 👎.
| uses: actions/checkout@v5 | ||
| with: | ||
| repository: fluent/fluent-bit-docs | ||
| token: ${{ secrets.GH_PA_TOKEN }} |
There was a problem hiding this comment.
@edsiper / @cosmo0920 need to add ref: 4.1 here otherwise it'll checkout master branch
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.
Summary by CodeRabbit