-
Notifications
You must be signed in to change notification settings - Fork 49.9k
add browser testing to travis #628
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add browser testing to travis #628
Conversation
|
|
|
Perhaps |
|
The reason I want to change this is so that I can add more |
|
I mean, you could do that but I don't see the advantage over having the logic contained to .travis.yml. |
|
Maybe the best solution here is to have three test types: build, test, lint. Then we can run |
|
Currently I have each version of IE separated out as a separate matrix and they are setup to be allowed to fail. Once we fix all the broken tests for each browser we can remove it from being allowed to fail and move it to the unit phase. That way the we won't regress browser support. |
|
The problem with travis matrix is that nothing is kept between builds. Ideally we wouldn't go through |
|
cc @zpao — As you wish. |
Gruntfile.js
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure it's necessary to leave these comments -- we can move stuff over from the failing matrix when they pass
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like that it makes me feel uneasy. We shouldn't feel comfortable with leaving it this way.
|
I'll just leave this here: #633 |
|
Blargh, flaky tests: #634 |
|
#635 should help the webdriver tests be less flaky |
|
Rebased with master |
|
#635 should be merged before this one |
Gruntfile.js
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you put these into a config file. This file is pretty noisy already.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#willfix
|
👍 otherwise. test test test :) |
Now you can use the saucelabs jazz locally also.
Moved the travis specific stuff back into the travis file
Add these back in as build blockers once those issues are fixed.
…k-cleanup add browser testing to travis
No description provided.