Skip to content

Conversation

@subtleGradient
Copy link
Contributor

No description provided.

@sophiebits
Copy link
Collaborator

grunt test already builds the files necessary to run the unit tests. The explicit build is necessary only so that the packaged files can be POSTed to zpao's server from the Travis scrip.

@subtleGradient
Copy link
Contributor Author

Perhaps unit should be renamed to travis:unit or something then?
Either way the same stuff is happening in the same order.

@subtleGradient
Copy link
Contributor Author

The reason I want to change this is so that I can add more matrix entries without complicating the travis script.

@sophiebits
Copy link
Collaborator

I mean, you could do that but I don't see the advantage over having the logic contained to .travis.yml.

@sophiebits
Copy link
Collaborator

Maybe the best solution here is to have three test types: build, test, lint. Then we can run grunt $TEST_TYPE always, and after_script can check for build, which makes more sense anyway.

@subtleGradient
Copy link
Contributor Author

Currently I have each version of IE separated out as a separate matrix and they are setup to be allowed to fail. Once we fix all the broken tests for each browser we can remove it from being allowed to fail and move it to the unit phase. That way the we won't regress browser support.

@subtleGradient
Copy link
Contributor Author

The problem with travis matrix is that nothing is kept between builds. Ideally we wouldn't go through npm install more than once, for example. For now this works though.

@subtleGradient
Copy link
Contributor Author

cc @zpao — As you wish.

Gruntfile.js Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure it's necessary to leave these comments -- we can move stuff over from the failing matrix when they pass

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like that it makes me feel uneasy. We shouldn't feel comfortable with leaving it this way.

@subtleGradient
Copy link
Contributor Author

I'll just leave this here: #633

@subtleGradient
Copy link
Contributor Author

Blargh, flaky tests: #634

@subtleGradient
Copy link
Contributor Author

#635 should help the webdriver tests be less flaky

@subtleGradient
Copy link
Contributor Author

Rebased with master

@subtleGradient
Copy link
Contributor Author

#635 should be merged before this one

Gruntfile.js Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you put these into a config file. This file is pretty noisy already.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#willfix

@zpao
Copy link
Member

zpao commented Dec 6, 2013

👍 otherwise. test test test :)

subtleGradient added a commit that referenced this pull request Dec 9, 2013
@subtleGradient subtleGradient merged commit 00c8160 into facebook:master Dec 9, 2013
@subtleGradient subtleGradient deleted the subtlegradient/travis-task-cleanup branch December 9, 2013 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants