fixes webdriver issues #635
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
There was a problem hiding this comment.
what's the third argument here?
Contributor
Author
There was a problem hiding this comment.
poll interval
Collaborator
There was a problem hiding this comment.
what's the default? why set the other intervals differently?
Contributor
Author
There was a problem hiding this comment.
50ms because I want to start the tests asap
Contributor
Author
There was a problem hiding this comment.
100ms because the tests can take a few seconds to run, but then I don't want to unnecessarily delay everything more than necessary.
Contributor
Author
|
The poll interval doesn't really matter, we can always tweak it later if we want. |
Member
There was a problem hiding this comment.
This is what polyfills are for? Or is the polyfill not loaded yet?
Contributor
Author
There was a problem hiding this comment.
Not loaded yet.
Member
|
👍 |
subtleGradient
added a commit
that referenced
this pull request
Dec 5, 2013
…river-test fixes webdriver issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.