-
Notifications
You must be signed in to change notification settings - Fork 49.8k
docs tips parent-child communication 2 #623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I would suggest adding it to the current page (http://facebook.github.io/react/tips/communicate-between-components.html) as "case 2" or something similar. |
|
Thanks for reminding me this is still here. Like I said in #602, joining the two really bloats up the tip entry too much, and I haven't found a way to title this appropriately for discoverability. I'm getting on it soon. |
|
Alright! Thx for improving the documentation! |
|
Is it good to be taken in? |
|
Gimme a little bit longer, I really don't like some phrasing right now (and the title doesn't make sense anymore) |
|
@vjeux alright, now it's acceptably short. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you don't need [' ... ']. this.refs.item0.animate();
docs tips parent-child communication 2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess you noticed it, but you mutate this.state here. Perhaps one could prefer filtering instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, though my preference is to keep the entry simple and not make newcomers wonder about too many things at the time. But I guess this isn't too much of an overhead.
Continuation of #602.