Skip to content

Conversation

@chenglou
Copy link
Contributor

#542

Any comment? I don't like the title too much. I prefer describing the situation, e.g. "Parent-Child Communication" rather than just state what the code does. Except there's more to parent-child communication (#478).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

key prop

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right, thx.

@johnthethird
Copy link

+1 I was scratching my head about this too for a while, until I realized its just javascript!

@chenglou
Copy link
Contributor Author

@johnthethird got any idea for a better title? Like what prompted you to look for this? "Passing arguments to callbacks" feels a bit too general.

@johnthethird
Copy link

@chenglou I think it should go in the existing section for Events. It describes all the events that React supports, but no example of how to pass params to those functions. I found this on Github as I was just about to write up a doc change but found you beat me to it.

@andreypopp
Copy link
Contributor

I don't think it should go into the existing section for Events (it's not directly related), but I think it's a great idea to link from some parts of the docs to related tips.

@chenglou
Copy link
Contributor Author

chenglou commented Dec 2, 2013

Alright, just updated. Some review is really needed.
For parent-child, I link to the Multiple Components doc page (props). For child-parent, I separated the entry into two because it was getting too long, among other reasons.

@petehunt
Copy link
Contributor

petehunt commented Dec 2, 2013

Let's just do the first one in this pull request. We can do the second one in a separate one. Can you factor it out? I'll accept it.

@chenglou
Copy link
Contributor Author

chenglou commented Dec 2, 2013

Done! So basically just added a link to the props section.

petehunt added a commit that referenced this pull request Dec 2, 2013
docs tips pass arguments to callbacks
@petehunt petehunt merged commit 22dc8fa into facebook:master Dec 2, 2013
@chenglou chenglou deleted the tips-bind branch December 2, 2013 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants