Skip to content

[DevTools] Stop recording reorders in disconnected subtrees #34464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 11, 2025
+6 −2
Merged

[DevTools] Stop recording reorders in disconnected subtrees #34464

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c9602e9
[DevTools] Stop recording reorders in disconnected subtrees
eps1lon Sep 10, 2025
7836f1f
Check callsite instead
eps1lon Sep 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions packages/react-devtools-shared/src/backend/fiber/renderer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4310,7 +4310,9 @@ export function attach(
virtualLevel + 1,
);
if ((updateFlags & ShouldResetChildren) !== NoUpdate) {
recordResetChildren(virtualInstance);
if (!isInDisconnectedSubtree) {
recordResetChildren(virtualInstance);
}
updateFlags &= ~ShouldResetChildren;
}
removePreviousSuspendedBy(
Expand Down Expand Up @@ -5097,7 +5099,9 @@ export function attach(
// We need to crawl the subtree for closest non-filtered Fibers
// so that we can display them in a flat children set.
if (fiberInstance !== null && fiberInstance.kind === FIBER_INSTANCE) {
recordResetChildren(fiberInstance);
if (!nextIsHidden && !isInDisconnectedSubtree) {
recordResetChildren(fiberInstance);
}

// We've handled the child order change for this Fiber.
// Since it's included, there's no need to invalidate parent child order.
Expand Down
Loading