[DevTools] Stop recording reorders in disconnected subtrees #34464
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
React Core Team
This was referenced Sep 11, 2025
sebmarkbage
approved these changes
Sep 11, 2025
eps1lon
force-pushed
the
sebbie/disconnected-reorder
branch
from
95f9679 to
7836f1f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test case is in the
storeStress-synctest which started failing after c97ec75Disconnected elements will not be registered in the frontend so recording a reorder would then crash in the store with "Cannot reorder children for node "X" because no matching node was found in the Store.".