Skip to content

Conversation

@christianbach
Copy link

Follow-up to PR #337 by @necolas to get the branch green and ready to merge.

  • Align example tokens with typed vars (use Types.CSSType for colors)
  • Update example createTheme overrides to css.types.color(...)

All tests (and Flow) pass locally. I don’t usually write Flow, so please sanity-check the annotations—thanks!

@christianbach christianbach requested a review from necolas as a code owner August 9, 2025 09:26
@meta-cla meta-cla bot added the cla signed label Aug 9, 2025
@christianbach christianbach changed the title fix failures for native css.types.* PR (#337) Fix type failures for native css.types.* PR (#337) Aug 9, 2025
@christianbach
Copy link
Author

christianbach commented Aug 10, 2025

@necolas Im suspecting that the GitHub action for benchmarks cant write I comment on this PR since its from a fork?

Note: In public repositories this action does not work in pull_request workflows when triggered by forks. Any attempt will be met with the error, Resource not accessible by integration. This is due to token restrictions put in place by GitHub Actions. 

https://github.com/peter-evans/create-or-update-comment

@necolas
Copy link
Contributor

necolas commented Aug 11, 2025

Merged in #337. Thanks for your patience

@necolas necolas closed this Aug 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants