Skip to content

Conversation

@necolas
Copy link
Contributor

@necolas necolas commented Jul 11, 2025

These functions pass the value straight through on native.

Fix #331

@github-actions
Copy link

github-actions bot commented Jul 11, 2025

workflow: benchmarks/size

Comparison of minified (terser) and compressed (brotli) size results, measured in bytes. Smaller is better.

Results Base Patch Ratio
react-strict-dom/dist/dom/index.js
· compressed 2,514 2,514 1.00
· minified 8,691 8,691 1.00
react-strict-dom/dist/dom/runtime.js
· compressed 855 855 1.00
· minified 2,435 2,435 1.00
react-strict-dom/dist/native/index.js
· compressed 16,445 16,514 1.00 +
· minified 63,057 63,268 1.00 +

@github-actions
Copy link

github-actions bot commented Jul 11, 2025

workflow: benchmarks/perf (native)

Comparison of performance test results, measured in operations per second. Larger is better.

Results Base Patch Ratio
css.create
· small 1,143,352 1,147,253 1.00 +
· small with units 494,914 495,814 1.00 +
· small with variables 658,419 652,466 0.99 -
· several small 355,309 355,811 1.00 +
· large 202,156 200,874 0.99 -
· large with polyfills 148,080 147,990 1.00 -
· complex 103,422 103,358 1.00 -
· unsupported 212,117 214,488 1.01 +
css.createTheme
· simple theme 225,392 225,506 1.00 +
· polyfill theme 212,330 211,051 0.99 -
css.props
· small 230,342 230,648 1.00 +
· small with units 188,743 187,231 0.99 -
· small with variables 113,667 112,033 0.99 -
· small with variables of units 82,747 82,355 1.00 -
· large 94,934 96,466 1.02 +
· large with polyfills 38,605 38,240 0.99 -
· complex 22,276 22,356 1.00 +
· unsupported 141,867 141,468 1.00 -
· simple merge 158,584 158,384 1.00 -
· wide merge 16,958 17,064 1.01 +
· deep merge 16,637 16,699 1.00 +
· themed merge 32,462 32,908 1.01 +

@christianbach
Copy link

LGTM!

These functions pass the value straight through on native.

Fix #331
@necolas necolas force-pushed the native/stylex-types branch from 5f33117 to 1c5b819 Compare August 11, 2025 14:04
@necolas necolas merged commit a00a841 into main Aug 11, 2025
7 checks passed
@necolas
Copy link
Contributor Author

necolas commented Aug 11, 2025

Sorry, I'm going to have to revert this. Meta doesn't support the types API for StyleX internally, which causes the RSD sync to fail. I'll figure out a way to exclude this code during internal syncs, so I can land it in OSS, but don't have time right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing css.types Polyfill in Native stylex Export Blocks Cross-Platform Usage

4 participants