Added #content hash to debugging link so that it scrolls to start of content on mobile #424
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vjeux
added a commit
that referenced
this pull request
Mar 29, 2015
…redux Added #content hash to debugging link so that it scrolls to start of content on mobile
Author
There was a problem hiding this comment.
Without this change, when clicking on the link on mobile you get sent to the Debugging page but scrolled to the top of the page. Because the menu system goes first and is long, it can seem like the page is broken or the content is missing.
Ultimately the site just needs better mobile support and links shouldn't have to require #content everywhere. But alas, that's where we are now.
jfrolich
pushed a commit
to jfrolich/react-native
that referenced
this pull request
Apr 22, 2020
acoates-ms
pushed a commit
to acoates-ms/react-native
that referenced
this pull request
Jun 1, 2020
ayushjainrksh
referenced
this pull request
in MLH-Fellowship/react-native
Jul 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.