Skip to content

Conversation

@seflless
Copy link

I wasn't sure how a PR for a gh-page should be made. I kept it simple and just changed the files that generate the final website changes. I did not commit any generated files.

@facebook-github-bot
Copy link
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at [email protected]. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ordered Debugging before Testing as one was user facing, and one was for contributors. I figure, you will generally use react before contributing.

vjeux added a commit that referenced this pull request Mar 29, 2015
Add basic documentation for debugging react native apps
@vjeux vjeux merged commit 288aa50 into facebook:master Mar 29, 2015
@vjeux
Copy link
Contributor

vjeux commented Mar 29, 2015

Merci! It's a great first draft, we'll improve it over time :)

@seflless
Copy link
Author

Awesome thanks. Noticed a small bug once it went live. I added a PR to fix it:
#424

@sahrens
Copy link
Contributor

sahrens commented Mar 29, 2015

Good stuff, thanks for helping out!

@seflless
Copy link
Author

No problem. Awesome project guys, after trying to make PhoneGap/Cordova work for me over the years, I'm loving this approach.

@benjamingr
Copy link

Nice work +1 was definitely looking for this.

jfrolich pushed a commit to jfrolich/react-native that referenced this pull request Apr 22, 2020
ayushjainrksh referenced this pull request in MLH-Fellowship/react-native Jul 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants