-
Notifications
You must be signed in to change notification settings - Fork 25k
Add basic documentation for debugging react native apps #420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at [email protected]. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ordered Debugging before Testing as one was user facing, and one was for contributors. I figure, you will generally use react before contributing.
Add basic documentation for debugging react native apps
|
Merci! It's a great first draft, we'll improve it over time :) |
|
Awesome thanks. Noticed a small bug once it went live. I added a PR to fix it: |
|
Good stuff, thanks for helping out! |
|
No problem. Awesome project guys, after trying to make PhoneGap/Cordova work for me over the years, I'm loving this approach. |
|
Nice work +1 was definitely looking for this. |
I wasn't sure how a PR for a gh-page should be made. I kept it simple and just changed the files that generate the final website changes. I did not commit any generated files.