Skip to content

localeIdentifier missing from flow type of I18nManager #31589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

localeIdentifier missing from flow type of I18nManager #31589

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4d2324c
localeIdentifier missing from flow type of I18nManager
acoates-ms May 25, 2021
a3ae587
localeIdentifier was not being included in I18n constants
acoates-ms May 25, 2021
60a25fa
prettier
acoates-ms May 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions Libraries/ReactNative/I18nManager.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,12 +13,13 @@ import NativeI18nManager from './NativeI18nManager';
const i18nConstants: {|
doLeftAndRightSwapInRTL: boolean,
isRTL: boolean,
localeIdentifier?: ?string,
|} = getI18nManagerConstants();

function getI18nManagerConstants() {
if (NativeI18nManager) {
const {isRTL, doLeftAndRightSwapInRTL} = NativeI18nManager.getConstants();
return {isRTL, doLeftAndRightSwapInRTL};
const {isRTL, doLeftAndRightSwapInRTL, localeIdentifier} = NativeI18nManager.getConstants();
Copy link

@analysis-bot analysis-bot May 25, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prettier/prettier: Replace isRTL,·doLeftAndRightSwapInRTL,·localeIdentifier with ⏎······isRTL,⏎······doLeftAndRightSwapInRTL,⏎······localeIdentifier,⏎····

return {isRTL, doLeftAndRightSwapInRTL, localeIdentifier};
}

return {
Expand All @@ -28,7 +29,11 @@ function getI18nManagerConstants() {
}

module.exports = {
getConstants: (): {|doLeftAndRightSwapInRTL: boolean, isRTL: boolean|} => {
getConstants: (): {|
doLeftAndRightSwapInRTL: boolean,
isRTL: boolean,
localeIdentifier: ?string,
|} => {
return i18nConstants;
},

Expand Down