localeIdentifier missing from flow type of I18nManager #31589
Closed
+12
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
38 tasks
analysis-bot
suggested changes
May 25, 2021
analysis-bot
left a comment
analysis-bot
left a comment
There was a problem hiding this comment.
Code analysis results:
eslintfound some issues. Runyarn lint --fixto automatically fix problems.
Libraries/ReactNative/I18nManager.js
Outdated
| if (NativeI18nManager) { | ||
| const {isRTL, doLeftAndRightSwapInRTL} = NativeI18nManager.getConstants(); | ||
| return {isRTL, doLeftAndRightSwapInRTL}; | ||
| const {isRTL, doLeftAndRightSwapInRTL, localeIdentifier} = NativeI18nManager.getConstants(); |
There was a problem hiding this comment.
prettier/prettier: Replace isRTL,·doLeftAndRightSwapInRTL,·localeIdentifier with ⏎······isRTL,⏎······doLeftAndRightSwapInRTL,⏎······localeIdentifier,⏎····
Base commit: 118489f |
Contributor
|
@fkgozali has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Contributor
Titozzz
pushed a commit
to Titozzz/react-native
that referenced
this pull request
Jun 7, 2021
Summary: facebook@23d9bf1 looks like it accidently removed `localeIdentifier` from I18nManager. ## Changelog <!-- Help reviewers and the release process by writing your own changelog entry. For an example, see: https://github.com/facebook/react-native/wiki/Changelog --> [General] [Fixed] - Re-added localeIdentifier to I18nManager constants Pull Request resolved: facebook#31589 Reviewed By: GijsWeterings Differential Revision: D28690202 Pulled By: fkgozali fbshipit-source-id: 543a491f89789bca5629e1251c94fd055ec4a801
tido64
pushed a commit
that referenced
this pull request
Jun 8, 2021
Summary: 23d9bf1 looks like it accidently removed `localeIdentifier` from I18nManager. ## Changelog <!-- Help reviewers and the release process by writing your own changelog entry. For an example, see: https://github.com/facebook/react-native/wiki/Changelog --> [General] [Fixed] - Re-added localeIdentifier to I18nManager constants Pull Request resolved: #31589 Reviewed By: GijsWeterings Differential Revision: D28690202 Pulled By: fkgozali fbshipit-source-id: 543a491f89789bca5629e1251c94fd055ec4a801
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
23d9bf1 looks like it accidently removed
localeIdentifierfrom I18nManager.Changelog
[General] [Fixed] - Re-added localeIdentifier to I18nManager constants
Test Plan