engine: align WithdrawalRequestV1 with EIP-7002 and consensus spec #549
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkalinin
approved these changes
May 17, 2024
Contributor
mkalinin
left a comment
mkalinin
left a comment
There was a problem hiding this comment.
I like the alignment part but the renaming can cause interop breaks between CL and EL. So we should be careful about when to introduce this change on the client side, at least it should be after devnet-0
Member
Author
|
Do we wanna include this for devnet-1? Might need more visibility on it first, I am not that familiar how you do this on the execution api side but maybe could bring this up in discord and see if there is any opposition to the change |
Merged
7 tasks
11 tasks
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an inconsistency between the withdrawal request defined in EIP-7002 (see validator_pubkey field and related PR), the consensus spec (see ExecutionLayerWithdrawalRequest), and the execution api.
This PR align the execution api spec WithdrawalRequestV1 with the other specs.
Most ELs currently return it as
validatorPublicKeywith the exception of Besu which usesvalidatorPubKey