chore: log errors on monotonicity fixes #553
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: c8d7d85 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
tynes
approved these changes
Apr 22, 2021
Contributor
|
We haven't had a montonicity error in quite some time which is good |
InoMurko
referenced
this pull request
in omgnetwork/optimism
May 25, 2021
* chore: log errors on monotonicity fixes * add changeset
agusduha
pushed a commit
that referenced
this pull request
Sep 25, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 6, 2025
* feat: fee splitter system (#469) ---- Co-authored-by: Disco <[email protected]> Co-authored-by: Flux <[email protected]> Co-authored-by: Chiin <[email protected]> * fix: failing tests (#553) * refactor: revenue sharing config (#538) * fix: pre pr and semgrep (#565) * fix: warnings (#571) * fix: tests failing on fork environment (#575) * fix: use encode call on constructors (#578) * feat: add integration splitter test (#581) * fix: integration test nits (#583) * test: more coverage on splitter tests (#594) --------- Co-authored-by: Chiin <[email protected]> * fix: add missing operator fee vault field (#616) * feat: invariants and tests (#595) * fix: ir informationals (#609) * fix: pre pr (#622) * refactor: use cdm (#624) * fix: update withdrawal gas limit value on check (#627) * fix: remove rev share field from deploy op chain input struct (#628) * refactor: remove initializer and vaults getter changes (#631) * fix: remove immutable check over vaults (#634) Co-authored-by: 0xng <[email protected]> Co-authored-by: Funkornaut <[email protected]> Co-authored-by: Joxess <[email protected]> * fix: audit findings (#658) * fix: pre pr * feat: add user guide docs for rev sharing on op deployer (#666) * docs: add create2 comment (#667) --------- Co-authored-by: Funkornaut <[email protected]> Co-authored-by: Flux <[email protected]> Co-authored-by: Chiin <[email protected]> Co-authored-by: Simon Something /DrGoNoGo <[email protected]> Co-authored-by: 0xng <[email protected]> Co-authored-by: Joxess <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While discussing metrics, @K-Ho raised that batch submitter should not be fixing monotonicity errors (which should now be fully handled by geth). We want to be notified if it is, because that means there is a monotonicity violation and we need to debug geth. This PR logs an error when we fix monotonicity errors in batch submitter, which will then notify us through Sentry.
Additional context
log.errors are piped to sentry which notifies us.