-
Notifications
You must be signed in to change notification settings - Fork 3.8k
[WIP] feat: ChugSplash v0 #469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
Closing this until there's further activity! |
| ActionType _type, | ||
| string memory _target, | ||
| bytes memory _data, | ||
| uint256 _gasLimit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider adding a cancelDeployment function & requiring all calls pass
| /** | ||
| * @title ChugSplashDeployer | ||
| */ | ||
| contract ChugSplashDeployer { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider tradeoff of shutting down the system being encoded into the contract vs in the bundle
---- Co-authored-by: Disco <[email protected]> Co-authored-by: Flux <[email protected]> Co-authored-by: Chiin <[email protected]>
* feat: fee splitter system (#469) ---- Co-authored-by: Disco <[email protected]> Co-authored-by: Flux <[email protected]> Co-authored-by: Chiin <[email protected]> * fix: failing tests (#553) * refactor: revenue sharing config (#538) * fix: pre pr and semgrep (#565) * fix: warnings (#571) * fix: tests failing on fork environment (#575) * fix: use encode call on constructors (#578) * feat: add integration splitter test (#581) * fix: integration test nits (#583) * test: more coverage on splitter tests (#594) --------- Co-authored-by: Chiin <[email protected]> * fix: add missing operator fee vault field (#616) * feat: invariants and tests (#595) * fix: ir informationals (#609) * fix: pre pr (#622) * refactor: use cdm (#624) * fix: update withdrawal gas limit value on check (#627) * fix: remove rev share field from deploy op chain input struct (#628) * refactor: remove initializer and vaults getter changes (#631) * fix: remove immutable check over vaults (#634) Co-authored-by: 0xng <[email protected]> Co-authored-by: Funkornaut <[email protected]> Co-authored-by: Joxess <[email protected]> * fix: audit findings (#658) * fix: pre pr * feat: add user guide docs for rev sharing on op deployer (#666) * docs: add create2 comment (#667) --------- Co-authored-by: Funkornaut <[email protected]> Co-authored-by: Flux <[email protected]> Co-authored-by: Chiin <[email protected]> Co-authored-by: Simon Something /DrGoNoGo <[email protected]> Co-authored-by: 0xng <[email protected]> Co-authored-by: Joxess <[email protected]>
NOT READY FOR REVIEW
(I'm just using this as a way to keep track of my diff)
Description
Working on the various things necessary to get chugsplash off the ground.