Skip to content

Conversation

@smartcontracts
Copy link
Contributor

NOT READY FOR REVIEW

(I'm just using this as a way to keep track of my diff)

Description
Working on the various things necessary to get chugsplash off the ground.

@changeset-bot
Copy link

changeset-bot bot commented Apr 14, 2021

⚠️ No Changeset found

Latest commit: 24e9a19

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@gakonst
Copy link
Contributor

gakonst commented Apr 20, 2021

Closing this until there's further activity!

@gakonst gakonst closed this Apr 20, 2021
ActionType _type,
string memory _target,
bytes memory _data,
uint256 _gasLimit
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding a cancelDeployment function & requiring all calls pass

/**
* @title ChugSplashDeployer
*/
contract ChugSplashDeployer {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider tradeoff of shutting down the system being encoded into the contract vs in the bundle

@smartcontracts smartcontracts deleted the feat/chugsplash-deploy-v0 branch June 23, 2021 21:46
bap2pecs added a commit to babylonlabs-io/optimism that referenced this pull request Jul 31, 2024
agusduha pushed a commit that referenced this pull request Sep 25, 2025
----

Co-authored-by: Disco <[email protected]>
Co-authored-by: Flux <[email protected]>
Co-authored-by: Chiin <[email protected]>
github-merge-queue bot pushed a commit that referenced this pull request Nov 6, 2025
* feat: fee splitter system (#469)


----

Co-authored-by: Disco <[email protected]>
Co-authored-by: Flux <[email protected]>
Co-authored-by: Chiin <[email protected]>

* fix: failing tests (#553)

* refactor: revenue sharing config (#538)

* fix: pre pr and semgrep (#565)

* fix: warnings (#571)

* fix: tests failing on fork environment (#575)

* fix: use encode call on constructors (#578)

* feat: add integration splitter test (#581)

* fix: integration test nits (#583)

* test: more coverage on splitter tests (#594)


---------

Co-authored-by: Chiin <[email protected]>

* fix: add missing operator fee vault field (#616)

* feat: invariants and tests (#595)

* fix: ir informationals (#609)

* fix: pre pr (#622)

* refactor: use cdm (#624)

* fix: update withdrawal gas limit value on check (#627)

* fix: remove rev share field from deploy op chain input struct (#628)

* refactor: remove initializer and vaults getter changes (#631)

* fix: remove immutable check over vaults (#634)


Co-authored-by: 0xng <[email protected]>
Co-authored-by: Funkornaut <[email protected]>
Co-authored-by: Joxess <[email protected]>

* fix: audit findings (#658)

* fix: pre pr

* feat: add user guide docs for rev sharing on op deployer (#666)

* docs: add create2 comment (#667)

---------

Co-authored-by: Funkornaut <[email protected]>
Co-authored-by: Flux <[email protected]>
Co-authored-by: Chiin <[email protected]>
Co-authored-by: Simon Something /DrGoNoGo <[email protected]>
Co-authored-by: 0xng <[email protected]>
Co-authored-by: Joxess <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-feature Category: features

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants