Skip to content

Conversation

@Xunzhuo
Copy link
Member

@Xunzhuo Xunzhuo commented Dec 6, 2022

Fixes: #716

Signed-off-by: bitliu [email protected]

@Xunzhuo Xunzhuo requested a review from a team as a code owner December 6, 2022 04:37
@codecov-commenter
Copy link

codecov-commenter commented Dec 6, 2022

Codecov Report

Merging #778 (59ec039) into main (a7d1c9d) will increase coverage by 0.03%.
The diff coverage is 82.75%.

@@            Coverage Diff             @@
##             main     #778      +/-   ##
==========================================
+ Coverage   61.41%   61.45%   +0.03%     
==========================================
  Files          46       46              
  Lines        5653     5653              
==========================================
+ Hits         3472     3474       +2     
+ Misses       1954     1952       -2     
  Partials      227      227              
Impacted Files Coverage Δ
internal/gatewayapi/helpers_v1alpha2.go 20.63% <33.33%> (ø)
internal/gatewayapi/translator.go 85.34% <92.85%> (ø)
internal/gatewayapi/contexts.go 77.15% <100.00%> (ø)
internal/status/conditions.go 96.00% <100.00%> (ø)
internal/provider/kubernetes/helpers.go 75.80% <0.00%> (+1.61%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Xunzhuo Xunzhuo force-pushed the bump-gwapi branch 2 times, most recently from f375461 to 7a9d39d Compare December 6, 2022 08:12
@arkodg
Copy link
Contributor

arkodg commented Dec 6, 2022

hey @Xunzhuo looking at kubernetes-sigs/gateway-api#1499 & projectcontour/contour#4849 we might need to update the Ready Listener condition with Programmed

@Xunzhuo
Copy link
Member Author

Xunzhuo commented Dec 6, 2022

Cool, thanks @arkodg, I will update it later.

@youngnick
Copy link
Contributor

Yes, the two biggest changes are Ready -> Programmed, and the move of everything to Accepted for indicating attachment/accepted.

@arkodg
Copy link
Contributor

arkodg commented Dec 7, 2022

thanks @youngnick
@Xunzhuo this is the relevant PR reg Accepted condition kubernetes-sigs/gateway-api#1447

@Xunzhuo Xunzhuo changed the title chore: bump GWAPI to v0.6.0-rc1 feat: upgrade GWAPI to v0.6.0-rc1 Dec 7, 2022
@Xunzhuo Xunzhuo enabled auto-merge (squash) December 7, 2022 04:52
Signed-off-by: bitliu <[email protected]>
@Xunzhuo Xunzhuo requested a review from arkodg December 8, 2022 02:20
Signed-off-by: bitliu <[email protected]>
Signed-off-by: bitliu <[email protected]>
Copy link
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@Xunzhuo Xunzhuo merged commit cc6ac0c into envoyproxy:main Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/api API-related issues area/conformance Gateway API Conformance Related Issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update to the v0.6.0 Gateway API release

4 participants