Skip to content

Conversation

@Xunzhuo
Copy link
Member

@Xunzhuo Xunzhuo commented Nov 11, 2022

Resolves: #719

Signed-off-by: bitliu [email protected]

@Xunzhuo Xunzhuo marked this pull request as ready for review November 11, 2022 06:41
@Xunzhuo Xunzhuo requested a review from a team as a code owner November 11, 2022 06:42
@Xunzhuo Xunzhuo added this to the 0.3.0-rc.1 milestone Nov 11, 2022
@codecov-commenter
Copy link

codecov-commenter commented Nov 11, 2022

Codecov Report

Merging #725 (cc85637) into main (cc6ac0c) will decrease coverage by 0.10%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #725      +/-   ##
==========================================
- Coverage   61.26%   61.15%   -0.11%     
==========================================
  Files          46       46              
  Lines        5674     5674              
==========================================
- Hits         3476     3470       -6     
- Misses       1971     1977       +6     
  Partials      227      227              
Impacted Files Coverage Δ
internal/provider/kubernetes/helpers.go 71.77% <0.00%> (-1.62%) ⬇️
internal/provider/kubernetes/controller.go 51.45% <0.00%> (-0.78%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@danehans
Copy link
Contributor

/hold until #716 is fixed.

@Xunzhuo
Copy link
Member Author

Xunzhuo commented Dec 6, 2022

/unhold after #778 gets merged.

@Xunzhuo Xunzhuo enabled auto-merge (squash) December 8, 2022 02:38
@Xunzhuo Xunzhuo merged commit 13c1113 into envoyproxy:main Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bump Echoserver Image Tag

4 participants