Skip to content

Get node mver without regex #18738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 15, 2023
Merged

Get node mver without regex #18738

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b7bf2a8
Update shell.js
jeswr Feb 13, 2023
d2b0118
chore: don't cast nodeMajor as number
jeswr Feb 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/shell.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,7 +255,7 @@ if (ENVIRONMENT_IS_NODE) {
// not be needed with node v15 and about because it is now the default
// behaviour:
// See https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode
var nodeMajor = process.version.match(/^v(\d+)\./)[1];
var nodeMajor = process.versions.node.split(".")[0];
if (nodeMajor < 15) {
process['on']('unhandledRejection', function(reason) { throw reason; });
}
Expand Down