Skip to content

Conversation

@jeswr
Copy link
Contributor

@jeswr jeswr commented Feb 13, 2023

A quick PR to remove unnecessary regex (and also avoid a comparison between a string and a number) as noted in #18723 (comment)

@jeswr jeswr changed the title Update shell.js Get node mver without regex Feb 13, 2023
@jeswr jeswr requested a review from sbc100 February 15, 2023 12:35
@sbc100 sbc100 enabled auto-merge (squash) February 15, 2023 16:24
@sbc100 sbc100 merged commit e0c513b into emscripten-core:main Feb 15, 2023
@jeswr jeswr deleted the jeswr-patch-1 branch February 15, 2023 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants