Skip to content

add fetchInitialRevisions #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 1, 2016
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 18 additions & 3 deletions index.js
Original file line number Diff line number Diff line change
Expand Up @@ -128,14 +128,29 @@ module.exports = {
}
},

fetchRevisions: function(context) {
fetchInitialRevisions: function(/* context */) {
var redisDeployClient = this.readConfig('redisDeployClient');
var keyPrefix = this.readConfig('keyPrefix');
this.log('Listing initial revisions for key: `' + keyPrefix + '`', { verbose: true });
return Promise.resolve(redisDeployClient.fetchRevisions(keyPrefix))
.then(function(revisions) {
return {
initialRevisions: revisions
};
})
.catch(this._errorMessage.bind(this));
},

fetchRevisions: function(/* context */) {
var redisDeployClient = this.readConfig('redisDeployClient');
var keyPrefix = this.readConfig('keyPrefix');

this.log('Listing revisions for key: `' + keyPrefix + '`');
return Promise.resolve(redisDeployClient.fetchRevisions(keyPrefix))
.then(function(revisions){
return { revisions: revisions };
.then(function(revisions) {
return {
revisions: revisions
};
})
.catch(this._errorMessage.bind(this));
},
Expand Down
54 changes: 50 additions & 4 deletions tests/unit/index-nodetest.js
Original file line number Diff line number Diff line change
Expand Up @@ -575,8 +575,8 @@ describe('redis plugin', function() {
});
});

describe('fetchRevisions hook', function() {
it('fills the revisions variable on context', function() {
describe('fetchInitialRevisions hook', function() {
it('fills the initialRevisions variable on context', function() {
var plugin;
var context;

Expand Down Expand Up @@ -609,15 +609,61 @@ describe('redis plugin', function() {
plugin.beforeHook(context);
plugin.configure(context);

return assert.isFulfilled(plugin.fetchRevisions(context))
return assert.isFulfilled(plugin.fetchInitialRevisions(context))
.then(function(result) {
assert.deepEqual(result, {
revisions: [{
initialRevisions: [{
"active": false,
"revision": "a"
}]
});
});
});
});

describe('fetchRevisions hook', function() {
it('fills the revisions variable on context', function() {
var plugin;
var context;

plugin = subject.createDeployPlugin({
name: 'redis'
});

context = {
ui: mockUi,
project: stubProject,
config: {
redis: {
keyPrefix: 'test-prefix',
filePattern: 'index.html',
distDir: 'tests',
revisionKey: '123abc',
redisDeployClient: function(context) {
return {
fetchRevisions: function(keyPrefix, revisionKey) {
return Promise.resolve([{
revision: 'a',
active: false
}]);
}
};
}
}
}
};
plugin.beforeHook(context);
plugin.configure(context);

return assert.isFulfilled(plugin.fetchRevisions(context))
.then(function(result) {
assert.deepEqual(result, {
revisions: [{
"active": false,
"revision": "a"
}]
});
});
});
});
});