-
Notifications
You must be signed in to change notification settings - Fork 41
add fetchInitialRevisions #50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
fcd01fb
to
00f725a
Compare
@lukemelia initially I merged |
@ghedamat While writing 0.6.x docs, I rethought this a little (see results at http://ember-cli.com/ember-cli-deploy/docs/v0.6.x/pipeline-hooks/)
and
|
This would indeed be a breaking change. We need to think about backwards compatibility and/or messaging. |
@lukemelia I tend to agree, if we keep the properties separate we don't need to break any existing plugins and we can "reserve" the property names in the docs as you did I'll update the PR and do the other ones later this week |
00f725a
to
f8ebacc
Compare
@lukemelia should be good now and non breaking |
revisionData
keyrevisionData
key
revisionData
keyf8ebacc
to
3952614
Compare
describe('fetchRevisions hook', function() { | ||
it('fills the revisions variable on context', function() { | ||
describe('fetchInitialRevisions hook', function() { | ||
it('fills the revisionsData.initial variable on context', function() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
test name is no longer correct
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
right, will fix soon
this implements ember-cli-deploy/ember-cli-deploy#338
3952614
to
db146a8
Compare
this implements ember-cli-deploy/ember-cli-deploy#338