Add decline button to call notification toast (use new notification event) #30729

toger5 · 2025-09-09T15:14:15Z

This PR adds a couple of new conditions to the IncomingCallToast so that it gets dismissed in the right cases and provides an option to send decline events by pressing a decline button.
Additionally it now is possible to jumpt to the lobby by pressing the toast and joining and skipping the lobby by pressing the join button.

This make EW incompatible with the old style notify events.

Before	After

Signed-off-by: Timo K [email protected]

Checklist

Tests written for new code (and old code if feasible).
New or updated public/exported symbols have accurate TSDoc documentation.
Linter and other CI checks pass.
I have licensed the changes to Element by completing the Contributor License Agreement (CLA)

dbkr

Looks like there are quite a lot of visual changes here - any chance of a screenshot or two?

Also, you have some failing lint jobs.

toger5 · 2025-09-11T09:28:38Z

Looks like there are quite a lot of visual changes here - any chance of a screenshot or two?

you are right screenshots would be great. (I even prepared some yesterday...)

florianduros

I kind of thinking that this ui should be in the shared components:

res/css/views/toasts/_IncomingCallToast.pcss

toger5 · 2025-09-11T14:44:23Z

I kind of thinking that this ui should be in the shared components:

@florianduros
is this already sth in the compound tokens? or do you mean i should move this into a new shared component?

florianduros · 2025-09-11T14:56:35Z

@toger5 The shared components are not in compound but in src/shared-components folder of EW. They are using CSS modules, storybook and are pure view component. You can take a look at the existing components when launching the EW storybook.

Signed-off-by: Timo K <[email protected]>

src/shared-components/avatar/AvatarWithDetails/AvatarWithDetails.tsx

src/shared-components/avatar/AvatarWithDetails/AvatarWithDetails.stories.tsx

src/shared-components/avatar/AvatarWithDetails/AvatarWithDetails.tsx

src/toasts/IncomingCallToast.tsx

toger5 · 2025-09-16T08:19:50Z

I will brush up the doc strings and then merge it. Thx @florianduros

Signed-off-by: Timo K <[email protected]>

@richvdh

https://build.opensuse.org/request/show/1306767 by user dheidler + anag_factory - Version 1.12.0 ## 🦖 Deprecations * Remove remaining support for outdated .well-known settings (element-hq/element-web#30702). Contributed by @richvdh. ## ✨ Features * Add decline button to call notification toast (use new notification event) (element-hq/element-web#30729). Contributed by @toger5. * Use the new room list by default (element-hq/element-web#30640). Contributed by @langleyd. * "Verify this device" redesign (element-hq/element-web#30596). Contributed by @uhoreg. * Set Element Call "intents" when starting and answering DM calls. (element-hq/element-web#30730). Contributed by @Half-Shot. * Add axe compliance for new room list (https://github.com

@richvdh

https://build.opensuse.org/request/show/1306768 by user dheidler + anag_factory - Fix fix-oxc-resolver.patch - Version 1.12.0 ## 🦖 Deprecations * Remove remaining support for outdated .well-known settings (element-hq/element-web#30702). Contributed by @richvdh. ## ✨ Features * Automatically select first source for desktop capture under Wayland (element-hq/element-desktop#2526). Contributed by @byquanton. * Add decline button to call notification toast (use new notification event) (element-hq/element-web#30729). Contributed by @toger5. * Use the new room list by default (element-hq/element-web#30640). Contributed by @langleyd. * "Verify this device" redesign (element-hq/element-web#30596). Contributed by @uhoreg. * Set Element Call "int

…vent) (element-hq#30729) * Add decline button to call notification toast (use new notification event) - This make EW incompatible with the old style notify events. Signed-off-by: Timo K <[email protected]> * update styling for call toast Signed-off-by: Timo K <[email protected]> * skip lobby on join button click / dont skip lobby on toast click Signed-off-by: Timo K <[email protected]> * dismiss toast on remote decline Signed-off-by: Timo K <[email protected]> * fixup docstring and event_id Signed-off-by: Timo K <[email protected]> * Add tests Signed-off-by: Timo K <[email protected]> * remove unused var Signed-off-by: Timo K <[email protected]> * test that decline event gets sent Signed-off-by: Timo K <[email protected]> * make "go to lobby" accessible via keyboard (fix sonar cloud) Signed-off-by: Timo K <[email protected]> * remove keyboard input Signed-off-by: Timo K <[email protected]> * fix lint Signed-off-by: Timo K <[email protected]> * use actual button Signed-off-by: Timo K <[email protected]> * review style + toggle for join immediately Signed-off-by: Timo K <[email protected]> * fix `getNotificationEventSendTs` Signed-off-by: Timo K <[email protected]> * use story component Signed-off-by: Timo K <[email protected]> * english text Signed-off-by: Timo K <[email protected]> * dont use legacy toggle Signed-off-by: Timo K <[email protected]> * fix lint Signed-off-by: Timo K <[email protected]> * review Signed-off-by: Timo K <[email protected]> * review (mostly docs) Signed-off-by: Timo K <[email protected]> --------- Signed-off-by: Timo K <[email protected]>

@langleyd

Changes in [1.12.2](https://github.com/element-hq/element-web/releases/tag/v1.12.2) (2025-10-21) ================================================================================================ * Room List: Extend the viewport to avoid so many black spots when scrolling the room list ([#30867](element-hq/element-web#30867)). Contributed by @langleyd. * Hide calling buttons in room header before a room is created ([#30816](element-hq/element-web#30816)). Contributed by @Half-Shot. * Improve invite dialog ui - Part 2 ([#30836](element-hq/element-web#30836)). Contributed by @florianduros. * Fix platform settings race condition and make auto-launch tri-state ([#30977](element-hq/element-web#30977)). Contributed by @t3chguy. * Fix: member count in header and member list ([#30982](element-hq/element-web#30982)). Contributed by @florianduros. * Fix duration of voice message in timeline ([#30973](element-hq/element-web#30973)). Contributed by @florianduros. * Fix voice notes rendering at 00:00 when playback had not begun. ([#30961](element-hq/element-web#30961)). Contributed by @Half-Shot. * Improve handling of animated images, add support for AVIF animations ([#30932](element-hq/element-web#30932)). Contributed by @t3chguy. * Update key storage toggle when key storage status changes ([#30934](element-hq/element-web#30934)). Contributed by @uhoreg. * Fix jitsi widget popout ([#30908](element-hq/element-web#30908)). Contributed by @dbkr. * Improve keyboard navigation on invite dialog ([#30930](element-hq/element-web#30930)). Contributed by @florianduros. * Prefer UIA flows with supported UIA stages ([#30926](element-hq/element-web#30926)). Contributed by @richvdh. * Enhance accessibility of dropdown ([#30928](element-hq/element-web#30928)). Contributed by @florianduros. * Improve accessibility of the `\<AvatarSetting> component ([#30907](element-hq/element-web#30907)). Contributed by @MidhunSureshR. Changes in [1.12.1](https://github.com/element-hq/element-web/releases/tag/v1.12.1) (2025-10-07) ================================================================================================ * New Room List: Change the order of filters to match those on mobile ([#30905](element-hq/element-web#30905)). Contributed by @langleyd. * New Room List: Don't clear filters on space change ([#30903](element-hq/element-web#30903)). Contributed by @langleyd. * Add release announcement for the sounds ([#30900](element-hq/element-web#30900)). Contributed by @langleyd. * Rich Text Editor: Add emoji suggestion support ([#30873](element-hq/element-web#30873)). Contributed by @langleyd. * feat: Disable session lock when running in element-desktop ([#30643](element-hq/element-web#30643)). Contributed by @kaylendog. * Improve invite dialog ui - Part 1 ([#30764](element-hq/element-web#30764)). Contributed by @florianduros. * Update Message Sound for Element ([#30804](element-hq/element-web#30804)). Contributed by @beatdemon. * Add new and improved ringtone ([#30761](element-hq/element-web#30761)). Contributed by @Half-Shot. * Disable RTE formatting buttons when the content contains a slash command ([#30802](element-hq/element-web#30802)). Contributed by @langleyd. * New Room List: Improve robustness of keyboard navigation ([#30888](element-hq/element-web#30888)). Contributed by @langleyd. * Fix a11y issue on list in invite dialog ([#30878](element-hq/element-web#30878)). Contributed by @florianduros. * Switch Export and Import Icons to match intuition ([#30805](element-hq/element-web#30805)). Contributed by @micartey. * Hide breadcrumb option when new room list is enabled ([#30869](element-hq/element-web#30869)). Contributed by @florianduros. * Avoid creating multiple call objects for the same widget ([#30839](element-hq/element-web#30839)). Contributed by @robintown. * Add a test for #29882, which is fixed by matrix-org/matrix-js-sdk#5016 ([#30835](element-hq/element-web#30835)). Contributed by @andybalaam. * fix: use `help_encryption_url` of config instead of hardcoded `https://element.io/help#encryption5` ([#30746](element-hq/element-web#30746)). Contributed by @florianduros. * Fix html export when feature\_jump\_to\_date is enabled ([#30828](element-hq/element-web#30828)). Contributed by @langleyd. * Fix #30439: "Forgot recovery key" should go to "reset" ([#30771](element-hq/element-web#30771)). Contributed by @andybalaam. Changes in [1.12.0](https://github.com/element-hq/element-web/releases/tag/v1.12.0) (2025-09-23) ================================================================================================ * Remove remaining support for outdated .well-known settings ([#30702](element-hq/element-web#30702)). Contributed by @richvdh. * Add decline button to call notification toast (use new notification event) ([#30729](element-hq/element-web#30729)). Contributed by @toger5. * Use the new room list by default ([#30640](element-hq/element-web#30640)). Contributed by @langleyd. * "Verify this device" redesign ([#30596](element-hq/element-web#30596)). Contributed by @uhoreg. * Set Element Call "intents" when starting and answering DM calls. ([#30730](element-hq/element-web#30730)). Contributed by @Half-Shot. * Add axe compliance for new room list ([#30700](element-hq/element-web#30700)). Contributed by @langleyd. * Stop ringing and remove toast if another device answers a RTC call. ([#30728](element-hq/element-web#30728)). Contributed by @Half-Shot. * Automatically adjust history visibility when making a room private ([#30713](element-hq/element-web#30713)). Contributed by @Half-Shot. * Release announcement for new room list ([#30675](element-hq/element-web#30675)). Contributed by @dbkr. * [Backport staging] Room list: make the filter resize correctly ([#30795](element-hq/element-web#30795)). Contributed by @RiotRobot. * [Backport staging] Avoid flicker of the room list filter on resize ([#30794](element-hq/element-web#30794)). Contributed by @RiotRobot. * Don't show release announcements while toasts are displayed ([#30770](element-hq/element-web#30770)). Contributed by @dbkr. * Fix enabling key backup not working if there is an untrusted key backup ([#30707](element-hq/element-web#30707)). Contributed by @Half-Shot. * Force `preload` to be false when setting an intent on an Element Call. ([#30759](element-hq/element-web#30759)). Contributed by @Half-Shot. * Fix handling of 413 server response when uploading media ([#30737](element-hq/element-web#30737)). Contributed by @hughns. * Make landmark navigation work with new room list ([#30747](element-hq/element-web#30747)). Contributed by @dbkr. * Prevent voice message from displaying spurious errors ([#30736](element-hq/element-web#30736)). Contributed by @florianduros. * Align default avatar and fix colors in composer pills ([#30739](element-hq/element-web#30739)). Contributed by @florianduros. * Use configured URL for link to desktop app in message search settings ([#30742](element-hq/element-web#30742)). Contributed by @t3chguy. * Fix history visibility when creating space rooms ([#30745](element-hq/element-web#30745)). Contributed by @dbkr. * Check HTML-encoded quotes when handling translations for embedded pages (such as welcome.html) ([#30743](element-hq/element-web#30743)). Contributed by @Half-Shot. * Fix local room encryption status always not enabled ([#30461](element-hq/element-web#30461)). Contributed by @BillCarsonFr. * fix: make url in topic in room intro clickable ([#30686](element-hq/element-web#30686)). Contributed by @florianduros. * Block change recovery key button while a change is ongoing. ([#30664](element-hq/element-web#30664)). Contributed by @Half-Shot. * Hide advanced settings during room creation when `UIFeature.advancedSettings=false` ([#30684](element-hq/element-web#30684)). Contributed by @florianduros. * A11y: improve accessibility of pinned messages ([#30558](element-hq/element-web#30558)). Contributed by @florianduros. Changes in [1.11.112](https://github.com/element-hq/element-web/releases/tag/v1.11.112) (2025-09-16) ==================================================================================================== Fix [CVE-2025-59161](https://www.cve.org/CVERecord?id=CVE-2025-59161) / [GHSA-m6c8-98f4-75rr](GHSA-m6c8-98f4-75rr) Changes in [1.11.111](https://github.com/element-hq/element-web/releases/tag/v1.11.111) (2025-09-10) ==================================================================================================== * Do not hide media from your own user by default ([#29797](element-hq/element-web#29797)). Contributed by @Half-Shot. * Remember whether sidebar is shown for calls when switching rooms ([#30262](element-hq/element-web#30262)). Contributed by @bojidar-bg. * Open the proper integration settings on integrations disabled error ([#30538](element-hq/element-web#30538)). Contributed by @Half-Shot. * Show a "progress" dialog while invites are being sent ([#30561](element-hq/element-web#30561)). Contributed by @richvdh. * Move the room list to the new ListView(backed by react-virtuoso) ([#30515](element-hq/element-web#30515)). Contributed by @langleyd. * [Backport staging] Ensure container starts if it is mounted with an empty /modules directory. ([#30705](element-hq/element-web#30705)). Contributed by @RiotRobot. * Fix room joining over federation not specifying vias or using aliases ([#30641](element-hq/element-web#30641)). Contributed by @t3chguy. * Fix stable-suffixed MSC4133 support ([#30649](element-hq/element-web#30649)). Contributed by @dbkr. * Fix i18n of message when a setting is disabled ([#30646](element-hq/element-web#30646)). Contributed by @dbkr. * ListView should not handle the arrow keys if there is a modifier applied ([#30633](element-hq/element-web#30633)). Contributed by @langleyd. * Make BaseDialog's div keyboard focusable and fix test. ([#30631](element-hq/element-web#30631)). Contributed by @langleyd. * Fix: Allow triple-click text selection to flow around pills ([#30349](element-hq/element-web#30349)). Contributed by @AlirezaMrtz. * Watch for a 'join' action to know when the call is connected ([#29492](element-hq/element-web#29492)). Contributed by @robintown. * Fix: add missing tooltip and aria-label to lock icon next to composer ([#30623](element-hq/element-web#30623)). Contributed by @florianduros. * Don't render context menu when scrolling ([#30613](element-hq/element-web#30613)). Contributed by @langleyd.

github-actions bot deployed to Netlify September 9, 2025 15:17 View deployment

github-actions bot deployed to EndToEndTests September 9, 2025 15:28 View deployment

toger5 added the T-Enhancement label Sep 10, 2025

toger5 force-pushed the toger5/decline-call-notify-event branch from dd09d3d to 38ef88e Compare September 10, 2025 14:50

github-actions bot deployed to Netlify September 10, 2025 14:53 View deployment

github-actions bot deployed to EndToEndTests September 10, 2025 15:03 View deployment

toger5 marked this pull request as ready for review September 10, 2025 16:10

toger5 requested a review from a team as a code owner September 10, 2025 16:10

toger5 requested review from dbkr and florianduros September 10, 2025 16:10

github-actions bot deployed to Netlify September 10, 2025 16:12 View deployment

github-actions bot deployed to EndToEndTests September 10, 2025 16:23 View deployment

dbkr reviewed Sep 11, 2025

View reviewed changes

toger5 requested a review from dbkr September 11, 2025 11:55

github-actions bot deployed to Netlify September 11, 2025 11:57 View deployment

github-actions bot deployed to EndToEndTests September 11, 2025 12:08 View deployment

github-actions bot deployed to Netlify September 11, 2025 12:39 View deployment

github-actions bot deployed to EndToEndTests September 11, 2025 12:49 View deployment

toger5 force-pushed the toger5/decline-call-notify-event branch from 7e8c5db to 5824840 Compare September 11, 2025 13:28

github-actions bot deployed to Netlify September 11, 2025 13:31 View deployment

github-actions bot deployed to Netlify September 11, 2025 13:38 View deployment

github-actions bot deployed to EndToEndTests September 11, 2025 13:51 View deployment

github-actions bot deployed to Netlify September 11, 2025 13:59 View deployment

github-actions bot deployed to EndToEndTests September 11, 2025 14:10 View deployment

florianduros reviewed Sep 11, 2025

View reviewed changes

res/css/views/toasts/_IncomingCallToast.pcss Outdated Show resolved Hide resolved

Half-Shot self-requested a review September 11, 2025 14:48

github-actions bot deployed to Netlify September 11, 2025 15:19 View deployment

toger5 added 5 commits September 15, 2025 14:56

use story component

62923a7

Signed-off-by: Timo K <[email protected]>

english text

0241577

Signed-off-by: Timo K <[email protected]>

dont use legacy toggle

cd0ba80

Signed-off-by: Timo K <[email protected]>

fix lint

67bddb2

Signed-off-by: Timo K <[email protected]>

review

b6fe854

Signed-off-by: Timo K <[email protected]>

toger5 force-pushed the toger5/decline-call-notify-event branch from 77a4c1e to b6fe854 Compare September 15, 2025 12:56

github-actions bot deployed to Netlify September 15, 2025 12:59 View deployment

github-actions bot deployed to EndToEndTests September 15, 2025 13:10 View deployment

toger5 requested a review from Half-Shot September 15, 2025 14:42

Half-Shot approved these changes Sep 15, 2025

View reviewed changes

florianduros approved these changes Sep 16, 2025

View reviewed changes

review (mostly docs)

09ca013

Signed-off-by: Timo K <[email protected]>

github-actions bot deployed to Netlify September 16, 2025 08:41 View deployment

github-actions bot deployed to EndToEndTests September 16, 2025 08:53 View deployment

toger5 added this pull request to the merge queue Sep 16, 2025

Merged via the queue into develop with commit 0783f27 Sep 16, 2025
35 checks passed

toger5 deleted the toger5/decline-call-notify-event branch September 16, 2025 10:57

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Add decline button to call notification toast (use new notification event) #30729

Add decline button to call notification toast (use new notification event) #30729

Uh oh!

toger5 commented Sep 9, 2025 •

edited

Loading

Uh oh!

dbkr left a comment

Uh oh!

toger5 commented Sep 11, 2025

Uh oh!

florianduros left a comment

Uh oh!

Uh oh!

toger5 commented Sep 11, 2025 •

edited

Loading

Uh oh!

florianduros commented Sep 11, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

toger5 commented Sep 16, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Add decline button to call notification toast (use new notification event) #30729

Add decline button to call notification toast (use new notification event) #30729

Uh oh!

Conversation

toger5 commented Sep 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

Uh oh!

dbkr left a comment

Choose a reason for hiding this comment

Uh oh!

toger5 commented Sep 11, 2025

Uh oh!

florianduros left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

toger5 commented Sep 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

florianduros commented Sep 11, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

toger5 commented Sep 16, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

toger5 commented Sep 9, 2025 •

edited

Loading

toger5 commented Sep 11, 2025 •

edited

Loading