"Verify this device" redesign #30596

uhoreg · 2025-08-19T18:03:47Z

Probably easiest to review commit-by-commit

Checklist

Tests written for new code (and old code if feasible).
New or updated public/exported symbols have accurate TSDoc documentation.
Linter and other CI checks pass.
I have licensed the changes to Element by completing the Contributor License Agreement (CLA)

uhoreg · 2025-08-20T15:16:52Z

res/css/views/auth/_CompleteSecurityBody.pcss

    background-color: $background;
    border-radius: 4px;
-    padding: 20px;
+    padding: 20px 20px 60px 20px;


For some reason that I haven't been able to figure out, it squishes the bottom of the dialog, so I had to add some extra padding here.

dosubot · 2025-08-20T15:49:17Z

Related Documentation

No published documentation to review for changes on this repository.
Write your first living document

^{How did I do? Any feedback?}

src/components/views/settings/encryption/ResetIdentityBody.tsx

t3chguy

Looks sane otherwise

src/components/structures/auth/SetupEncryptionBody.tsx

richvdh · 2025-08-22T11:49:51Z

I started reviewing this but I'm finding it really hard to follow. It's definitely too big to review in one lump, but the commits don't seem to make much sense either.

Could you try restructuring it, into smaller commits, with more explanation about what each commit is doing and why?

src/components/views/settings/encryption/ResetIdentityBody.tsx

src/i18n/strings/en_EN.json

src/components/views/settings/encryption/ResetIdentityBody.tsx

src/components/structures/auth/SetupEncryptionBody.tsx

res/css/structures/auth/_SetupEncryptionBody.pcss

res/css/views/settings/encryption/_EncryptionCard.pcss

src/components/views/auth/AuthPage.tsx

res/css/views/auth/_AuthPage.pcss

richvdh

LGTM otherwise

richvdh · 2025-09-12T09:00:17Z

res/css/views/auth/_AuthPage.pcss

-    &.mx_AuthPage_modal_noBlur {
-        box-shadow: none;
+    /* Apply a blurred shadow around the modal */
+    &.mx_AuthPage_modal_blur {


this name feels too close to the already-existing (and different) mx_AuthPage_modalBlur

That's why I suggested mx_AuthPage_modal_withBlur, but feel free to come up with something else.

Right. I've changed it to your suggestion

* add variant of ResetIdentityBody for when the user has no verif. methods * no longer distinguish between the using having a passphrase or not * use vertical stack of buttons via EncryptionCard and update wording * swap logic order to match rendering order * use the same dialog when no verification options available * make it agree with the design more * allow signing out on initial login * apply styling changes and remove duplicate elements * fix and add tests * add missing snapshot * Apply suggestions from code review Co-authored-by: Richard van der Hoff <[email protected]> * use a boolean property to disable blurring instead of adding a class * change string identifiers * apply changes from review -- simplify logic * change class name to avoid confusion --------- Co-authored-by: Richard van der Hoff <[email protected]>

@richvdh

https://build.opensuse.org/request/show/1306767 by user dheidler + anag_factory - Version 1.12.0 ## 🦖 Deprecations * Remove remaining support for outdated .well-known settings (element-hq/element-web#30702). Contributed by @richvdh. ## ✨ Features * Add decline button to call notification toast (use new notification event) (element-hq/element-web#30729). Contributed by @toger5. * Use the new room list by default (element-hq/element-web#30640). Contributed by @langleyd. * "Verify this device" redesign (element-hq/element-web#30596). Contributed by @uhoreg. * Set Element Call "intents" when starting and answering DM calls. (element-hq/element-web#30730). Contributed by @Half-Shot. * Add axe compliance for new room list (https://github.com

@richvdh

https://build.opensuse.org/request/show/1306768 by user dheidler + anag_factory - Fix fix-oxc-resolver.patch - Version 1.12.0 ## 🦖 Deprecations * Remove remaining support for outdated .well-known settings (element-hq/element-web#30702). Contributed by @richvdh. ## ✨ Features * Automatically select first source for desktop capture under Wayland (element-hq/element-desktop#2526). Contributed by @byquanton. * Add decline button to call notification toast (use new notification event) (element-hq/element-web#30729). Contributed by @toger5. * Use the new room list by default (element-hq/element-web#30640). Contributed by @langleyd. * "Verify this device" redesign (element-hq/element-web#30596). Contributed by @uhoreg. * Set Element Call "int

* add variant of ResetIdentityBody for when the user has no verif. methods * no longer distinguish between the using having a passphrase or not * use vertical stack of buttons via EncryptionCard and update wording * swap logic order to match rendering order * use the same dialog when no verification options available * make it agree with the design more * allow signing out on initial login * apply styling changes and remove duplicate elements * fix and add tests * add missing snapshot * Apply suggestions from code review Co-authored-by: Richard van der Hoff <[email protected]> * use a boolean property to disable blurring instead of adding a class * change string identifiers * apply changes from review -- simplify logic * change class name to avoid confusion --------- Co-authored-by: Richard van der Hoff <[email protected]>

@langleyd

Changes in [1.12.2](https://github.com/element-hq/element-web/releases/tag/v1.12.2) (2025-10-21) ================================================================================================ * Room List: Extend the viewport to avoid so many black spots when scrolling the room list ([#30867](element-hq/element-web#30867)). Contributed by @langleyd. * Hide calling buttons in room header before a room is created ([#30816](element-hq/element-web#30816)). Contributed by @Half-Shot. * Improve invite dialog ui - Part 2 ([#30836](element-hq/element-web#30836)). Contributed by @florianduros. * Fix platform settings race condition and make auto-launch tri-state ([#30977](element-hq/element-web#30977)). Contributed by @t3chguy. * Fix: member count in header and member list ([#30982](element-hq/element-web#30982)). Contributed by @florianduros. * Fix duration of voice message in timeline ([#30973](element-hq/element-web#30973)). Contributed by @florianduros. * Fix voice notes rendering at 00:00 when playback had not begun. ([#30961](element-hq/element-web#30961)). Contributed by @Half-Shot. * Improve handling of animated images, add support for AVIF animations ([#30932](element-hq/element-web#30932)). Contributed by @t3chguy. * Update key storage toggle when key storage status changes ([#30934](element-hq/element-web#30934)). Contributed by @uhoreg. * Fix jitsi widget popout ([#30908](element-hq/element-web#30908)). Contributed by @dbkr. * Improve keyboard navigation on invite dialog ([#30930](element-hq/element-web#30930)). Contributed by @florianduros. * Prefer UIA flows with supported UIA stages ([#30926](element-hq/element-web#30926)). Contributed by @richvdh. * Enhance accessibility of dropdown ([#30928](element-hq/element-web#30928)). Contributed by @florianduros. * Improve accessibility of the `\<AvatarSetting> component ([#30907](element-hq/element-web#30907)). Contributed by @MidhunSureshR. Changes in [1.12.1](https://github.com/element-hq/element-web/releases/tag/v1.12.1) (2025-10-07) ================================================================================================ * New Room List: Change the order of filters to match those on mobile ([#30905](element-hq/element-web#30905)). Contributed by @langleyd. * New Room List: Don't clear filters on space change ([#30903](element-hq/element-web#30903)). Contributed by @langleyd. * Add release announcement for the sounds ([#30900](element-hq/element-web#30900)). Contributed by @langleyd. * Rich Text Editor: Add emoji suggestion support ([#30873](element-hq/element-web#30873)). Contributed by @langleyd. * feat: Disable session lock when running in element-desktop ([#30643](element-hq/element-web#30643)). Contributed by @kaylendog. * Improve invite dialog ui - Part 1 ([#30764](element-hq/element-web#30764)). Contributed by @florianduros. * Update Message Sound for Element ([#30804](element-hq/element-web#30804)). Contributed by @beatdemon. * Add new and improved ringtone ([#30761](element-hq/element-web#30761)). Contributed by @Half-Shot. * Disable RTE formatting buttons when the content contains a slash command ([#30802](element-hq/element-web#30802)). Contributed by @langleyd. * New Room List: Improve robustness of keyboard navigation ([#30888](element-hq/element-web#30888)). Contributed by @langleyd. * Fix a11y issue on list in invite dialog ([#30878](element-hq/element-web#30878)). Contributed by @florianduros. * Switch Export and Import Icons to match intuition ([#30805](element-hq/element-web#30805)). Contributed by @micartey. * Hide breadcrumb option when new room list is enabled ([#30869](element-hq/element-web#30869)). Contributed by @florianduros. * Avoid creating multiple call objects for the same widget ([#30839](element-hq/element-web#30839)). Contributed by @robintown. * Add a test for #29882, which is fixed by matrix-org/matrix-js-sdk#5016 ([#30835](element-hq/element-web#30835)). Contributed by @andybalaam. * fix: use `help_encryption_url` of config instead of hardcoded `https://element.io/help#encryption5` ([#30746](element-hq/element-web#30746)). Contributed by @florianduros. * Fix html export when feature\_jump\_to\_date is enabled ([#30828](element-hq/element-web#30828)). Contributed by @langleyd. * Fix #30439: "Forgot recovery key" should go to "reset" ([#30771](element-hq/element-web#30771)). Contributed by @andybalaam. Changes in [1.12.0](https://github.com/element-hq/element-web/releases/tag/v1.12.0) (2025-09-23) ================================================================================================ * Remove remaining support for outdated .well-known settings ([#30702](element-hq/element-web#30702)). Contributed by @richvdh. * Add decline button to call notification toast (use new notification event) ([#30729](element-hq/element-web#30729)). Contributed by @toger5. * Use the new room list by default ([#30640](element-hq/element-web#30640)). Contributed by @langleyd. * "Verify this device" redesign ([#30596](element-hq/element-web#30596)). Contributed by @uhoreg. * Set Element Call "intents" when starting and answering DM calls. ([#30730](element-hq/element-web#30730)). Contributed by @Half-Shot. * Add axe compliance for new room list ([#30700](element-hq/element-web#30700)). Contributed by @langleyd. * Stop ringing and remove toast if another device answers a RTC call. ([#30728](element-hq/element-web#30728)). Contributed by @Half-Shot. * Automatically adjust history visibility when making a room private ([#30713](element-hq/element-web#30713)). Contributed by @Half-Shot. * Release announcement for new room list ([#30675](element-hq/element-web#30675)). Contributed by @dbkr. * [Backport staging] Room list: make the filter resize correctly ([#30795](element-hq/element-web#30795)). Contributed by @RiotRobot. * [Backport staging] Avoid flicker of the room list filter on resize ([#30794](element-hq/element-web#30794)). Contributed by @RiotRobot. * Don't show release announcements while toasts are displayed ([#30770](element-hq/element-web#30770)). Contributed by @dbkr. * Fix enabling key backup not working if there is an untrusted key backup ([#30707](element-hq/element-web#30707)). Contributed by @Half-Shot. * Force `preload` to be false when setting an intent on an Element Call. ([#30759](element-hq/element-web#30759)). Contributed by @Half-Shot. * Fix handling of 413 server response when uploading media ([#30737](element-hq/element-web#30737)). Contributed by @hughns. * Make landmark navigation work with new room list ([#30747](element-hq/element-web#30747)). Contributed by @dbkr. * Prevent voice message from displaying spurious errors ([#30736](element-hq/element-web#30736)). Contributed by @florianduros. * Align default avatar and fix colors in composer pills ([#30739](element-hq/element-web#30739)). Contributed by @florianduros. * Use configured URL for link to desktop app in message search settings ([#30742](element-hq/element-web#30742)). Contributed by @t3chguy. * Fix history visibility when creating space rooms ([#30745](element-hq/element-web#30745)). Contributed by @dbkr. * Check HTML-encoded quotes when handling translations for embedded pages (such as welcome.html) ([#30743](element-hq/element-web#30743)). Contributed by @Half-Shot. * Fix local room encryption status always not enabled ([#30461](element-hq/element-web#30461)). Contributed by @BillCarsonFr. * fix: make url in topic in room intro clickable ([#30686](element-hq/element-web#30686)). Contributed by @florianduros. * Block change recovery key button while a change is ongoing. ([#30664](element-hq/element-web#30664)). Contributed by @Half-Shot. * Hide advanced settings during room creation when `UIFeature.advancedSettings=false` ([#30684](element-hq/element-web#30684)). Contributed by @florianduros. * A11y: improve accessibility of pinned messages ([#30558](element-hq/element-web#30558)). Contributed by @florianduros. Changes in [1.11.112](https://github.com/element-hq/element-web/releases/tag/v1.11.112) (2025-09-16) ==================================================================================================== Fix [CVE-2025-59161](https://www.cve.org/CVERecord?id=CVE-2025-59161) / [GHSA-m6c8-98f4-75rr](GHSA-m6c8-98f4-75rr) Changes in [1.11.111](https://github.com/element-hq/element-web/releases/tag/v1.11.111) (2025-09-10) ==================================================================================================== * Do not hide media from your own user by default ([#29797](element-hq/element-web#29797)). Contributed by @Half-Shot. * Remember whether sidebar is shown for calls when switching rooms ([#30262](element-hq/element-web#30262)). Contributed by @bojidar-bg. * Open the proper integration settings on integrations disabled error ([#30538](element-hq/element-web#30538)). Contributed by @Half-Shot. * Show a "progress" dialog while invites are being sent ([#30561](element-hq/element-web#30561)). Contributed by @richvdh. * Move the room list to the new ListView(backed by react-virtuoso) ([#30515](element-hq/element-web#30515)). Contributed by @langleyd. * [Backport staging] Ensure container starts if it is mounted with an empty /modules directory. ([#30705](element-hq/element-web#30705)). Contributed by @RiotRobot. * Fix room joining over federation not specifying vias or using aliases ([#30641](element-hq/element-web#30641)). Contributed by @t3chguy. * Fix stable-suffixed MSC4133 support ([#30649](element-hq/element-web#30649)). Contributed by @dbkr. * Fix i18n of message when a setting is disabled ([#30646](element-hq/element-web#30646)). Contributed by @dbkr. * ListView should not handle the arrow keys if there is a modifier applied ([#30633](element-hq/element-web#30633)). Contributed by @langleyd. * Make BaseDialog's div keyboard focusable and fix test. ([#30631](element-hq/element-web#30631)). Contributed by @langleyd. * Fix: Allow triple-click text selection to flow around pills ([#30349](element-hq/element-web#30349)). Contributed by @AlirezaMrtz. * Watch for a 'join' action to know when the call is connected ([#29492](element-hq/element-web#29492)). Contributed by @robintown. * Fix: add missing tooltip and aria-label to lock icon next to composer ([#30623](element-hq/element-web#30623)). Contributed by @florianduros. * Don't render context menu when scrolling ([#30613](element-hq/element-web#30613)). Contributed by @langleyd.

uhoreg added the T-Feature Request to add a new feature which does not exist right now label Aug 19, 2025

github-actions bot deployed to Netlify August 19, 2025 18:51 View deployment

uhoreg added T-Enhancement and removed T-Feature Request to add a new feature which does not exist right now labels Aug 19, 2025

github-actions bot deployed to EndToEndTests August 19, 2025 19:12 View deployment

github-actions bot deployed to Netlify August 19, 2025 19:19 View deployment

github-actions bot deployed to EndToEndTests August 19, 2025 19:39 View deployment

github-actions bot deployed to Netlify August 19, 2025 20:03 View deployment

github-actions bot deployed to EndToEndTests August 19, 2025 20:17 View deployment

uhoreg force-pushed the verify_device_redesign branch from 65a2a47 to 758647f Compare August 19, 2025 21:08

github-actions bot deployed to Netlify August 19, 2025 21:11 View deployment

github-actions bot deployed to EndToEndTests August 19, 2025 21:24 View deployment

uhoreg commented Aug 20, 2025

View reviewed changes

uhoreg marked this pull request as ready for review August 20, 2025 15:49

uhoreg requested review from a team as code owners August 20, 2025 15:49

uhoreg requested review from MidhunSureshR, richvdh and t3chguy August 20, 2025 15:49

t3chguy reviewed Aug 20, 2025

View reviewed changes

src/components/views/settings/encryption/ResetIdentityBody.tsx Outdated Show resolved Hide resolved

t3chguy reviewed Aug 20, 2025

View reviewed changes

src/components/structures/auth/SetupEncryptionBody.tsx Outdated Show resolved Hide resolved

github-actions bot deployed to Netlify August 20, 2025 17:47 View deployment

github-actions bot deployed to EndToEndTests August 20, 2025 17:57 View deployment

uhoreg requested a review from t3chguy August 20, 2025 19:20

t3chguy approved these changes Aug 21, 2025

View reviewed changes

richvdh reviewed Aug 22, 2025

View reviewed changes

uhoreg added 2 commits August 27, 2025 17:16

add variant of ResetIdentityBody for when the user has no verif. methods

0fdc4d2

no longer distinguish between the using having a passphrase or not

63dce71

uhoreg force-pushed the verify_device_redesign branch from 0f34b5b to 8212149 Compare September 4, 2025 13:58

github-actions bot deployed to Netlify September 4, 2025 14:02 View deployment

github-actions bot deployed to EndToEndTests September 4, 2025 14:14 View deployment

uhoreg requested a review from richvdh September 4, 2025 14:46

richvdh reviewed Sep 11, 2025

View reviewed changes

src/components/views/auth/AuthPage.tsx Show resolved Hide resolved

res/css/views/auth/_AuthPage.pcss Outdated Show resolved Hide resolved

res/css/views/auth/_AuthPage.pcss Outdated Show resolved Hide resolved

uhoreg added 2 commits September 11, 2025 13:44

Merge branch 'develop' into verify_device_redesign

b1d650e

apply changes from review -- simplify logic

ce42a8d

github-actions bot deployed to Netlify September 11, 2025 17:51 View deployment

github-actions bot deployed to EndToEndTests September 11, 2025 18:01 View deployment

uhoreg requested a review from richvdh September 11, 2025 18:20

richvdh approved these changes Sep 12, 2025

View reviewed changes

change class name to avoid confusion

6ad4321

github-actions bot deployed to Netlify September 12, 2025 18:17 View deployment

github-actions bot deployed to EndToEndTests September 12, 2025 18:27 View deployment

uhoreg added this pull request to the merge queue Sep 12, 2025

Merged via the queue into element-hq:develop with commit 9ad239f Sep 12, 2025
31 checks passed

uhoreg deleted the verify_device_redesign branch September 12, 2025 18:53

Uh oh!

"Verify this device" redesign #30596

"Verify this device" redesign #30596

Uh oh!

Conversation

uhoreg commented Aug 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

Uh oh!

uhoreg Aug 20, 2025

Choose a reason for hiding this comment

Uh oh!

dosubot bot commented Aug 20, 2025

Uh oh!

Uh oh!

t3chguy left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

richvdh commented Aug 22, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

richvdh left a comment

Choose a reason for hiding this comment

Uh oh!

richvdh Sep 12, 2025

Choose a reason for hiding this comment

Uh oh!

uhoreg Sep 12, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

uhoreg commented Aug 19, 2025 •

edited

Loading