Skip to content

If props are not omitted overwriting them should work for UnstyledButton #382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 4, 2025
Merged

If props are not omitted overwriting them should work for UnstyledButton #382

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bf44a72
Allow override of button role
langleyd Sep 3, 2025
18f42ad
Allow tabIndex and aria-disabled be overridden also.
langleyd Sep 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/components/Button/UnstyledButton.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,12 +83,13 @@ export const UnstyledButton = forwardRef(function UnstyledButton<

return (
<Component
// The elements roles should be set to button default, or link in the case of anchors.
// This should be overridable by props, say for example if you want to use a button as an option within a listbox.
// Hence it taking precedence over restProps.
role={as === "a" ? "link" : "button"}
{...restProps}
ref={ref as Ref<C>}
className={className}
// All elements roles should be overriden at the exceptions of anchors
// We want them to behave like links but look like buttons
role={as === "a" ? "link" : "button"}
tabIndex={0}
{...eventHandlers}
aria-disabled={disabled}
Expand Down
Loading