If props are not omitted overwriting them should work for UnstyledButton #382
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
langleyd
requested review from
dbkr and
t3chguy
and removed request for
a team
t3chguy
reviewed
Sep 4, 2025
Member
t3chguy
left a comment
t3chguy
left a comment
There was a problem hiding this comment.
Given the Prop types of this component, shouldn't the same be the case for the other props too? Either they should work or they should be Omited from the type
langleyd
changed the title
Deploying compound-web with
|
| Latest commit: |
18f42ad
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://3b09134e.compound-web.pages.dev |
| Branch Preview URL: | https://langleyd-allowoverrideofbutt.compound-web.pages.dev |
t3chguy
approved these changes
Sep 4, 2025
langleyd
changed the title
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If props are not Omitted overwriting them should work for UnstyledButton. For the new chat filters on the new room list in element web we are using listbox/option as roles, so we need to be able to override the role of the button.