Add captions to user and space grid pages #82713
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
legrego
added
Team:Security
Contributor
|
Pinging @elastic/kibana-security (Team:Security) |
Contributor
Member
Author
|
@lizozom sorry I don't have access to the link you posted. Are there additional changes I need to make in this PR? |
Contributor
|
Pinging @elastic/kibana-accessibility (Project:Accessibility) |
myasonik
approved these changes
Nov 5, 2020
Contributor
myasonik
left a comment
myasonik
left a comment
There was a problem hiding this comment.
The fix looks great, just a small nit on wording!
🎉 🎉 🎉
x-pack/plugins/security/public/management/users/users_grid/users_grid_page.tsx
Show resolved
Hide resolved
x-pack/plugins/spaces/public/management/spaces_grid/spaces_grid_page.tsx
Show resolved
Hide resolved
Member
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build SucceededMetrics [docs]async chunks size
page load bundle size
History
To update your PR or re-run it, just comment with: |
thomheymann
approved these changes
Nov 9, 2020
Contributor
thomheymann
left a comment
thomheymann
left a comment
There was a problem hiding this comment.
LGTM.
Caption comes through correctly (Users; Page 1 of 1. and Kibana spaces; Page 1 of 1.) and row headers (<th scope="row">) are set correctly for both tables.
This was referenced Nov 9, 2020
legrego
added a commit
to legrego/kibana
that referenced
this pull request
Nov 9, 2020
* Add captions to user and space grid pages * Address PR feedback: reword captions * remove unused i18n values Co-authored-by: Kibana Machine <[email protected]>
legrego
added a commit
that referenced
this pull request
Nov 9, 2020
* Add captions to user and space grid pages * Address PR feedback: reword captions * remove unused i18n values Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Kibana Machine <[email protected]>
legrego
added a commit
that referenced
this pull request
Nov 9, 2020
* Add captions to user and space grid pages * Address PR feedback: reword captions * remove unused i18n values Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Kibana Machine <[email protected]>
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Nov 10, 2020
* master: (39 commits) Fix ilm navigation (elastic#81664) [Lens] Distinct icons for XY and pie chart value labels toolbar (elastic#82927) [data.search.aggs] Throw an error when trying to create an agg type that doesn't exist. (elastic#81509) Index patterns api - load field list on server (elastic#82629) New events resolver (elastic#82170) [App Search] Misc naming tech debt (elastic#82770) load empty_kibana in test to have clean starting point (elastic#82772) Remove data <--> expressions circular dependencies. (elastic#82685) Update 8.0 breaking change template to gather information on how to programmatically detect it. (elastic#82905) Add alerting as codeowners to related documentation folder (elastic#82777) Add captions to user and space grid pages (elastic#82713) add alternate path for x-pack/Cloud test for Lens (elastic#82634) Uses asCurrentUser in getClusterUuid (elastic#82908) [Alerting][Connectors] Add new executor subaction to get 3rd party case fields (elastic#82519) Fix test import objects (elastic#82767) [ML] Add option for anomaly charts for metric detector should plot min, mean or max as appropriate (elastic#81662) Update alert type selection layout to rows instead of grid (elastic#73665) Prevent Kerberos and PKI providers from initiating a new session for unauthenticated XHR/API requests. (elastic#82817) Update grunt and related packages (elastic#79327) Allow the repository to search across all namespaces (elastic#82863) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds table captions to the user and space grid pages to improve accessibly.
Resolves #43018
Resolves #42505