Skip to content

Commit 3a8849f

Browse files
[7.10] Add captions to user and space grid pages (#82713) (#83004)
* Add captions to user and space grid pages * Address PR feedback: reword captions * remove unused i18n values Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Kibana Machine <[email protected]>
1 parent 8d998a3 commit 3a8849f

File tree

3 files changed

+10
-0
lines changed

3 files changed

+10
-0
lines changed

x-pack/plugins/security/public/management/users/users_grid/users_grid_page.tsx

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -259,6 +259,10 @@ export class UsersGridPage extends Component<Props, State> {
259259
{
260260
<EuiInMemoryTable
261261
itemId="username"
262+
tableCaption={i18n.translate('xpack.security.management.users.tableCaption', {
263+
defaultMessage: 'Users',
264+
})}
265+
rowHeader="username"
262266
columns={columns}
263267
selection={selectionConfig}
264268
pagination={pagination}

x-pack/plugins/spaces/public/management/spaces_grid/__snapshots__/spaces_grid_pages.test.tsx.snap

Lines changed: 2 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

x-pack/plugins/spaces/public/management/spaces_grid/spaces_grid_page.tsx

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -110,6 +110,10 @@ export class SpacesGridPage extends Component<Props, State> {
110110
<EuiInMemoryTable
111111
itemId={'id'}
112112
items={this.state.spaces}
113+
tableCaption={i18n.translate('xpack.spaces.management.spacesGridPage.tableCaption', {
114+
defaultMessage: 'Kibana spaces',
115+
})}
116+
rowHeader="name"
113117
columns={this.getColumnConfig()}
114118
hasActions
115119
pagination={true}

0 commit comments

Comments
 (0)