Add support for the rollup search API #3449
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mpdreamz
force-pushed
the
feature/rollup-search
branch
from
f8906fa to
1c27616
Compare
russcam
suggested changes
Oct 16, 2018
Contributor
russcam
left a comment
russcam
left a comment
There was a problem hiding this comment.
I left some general comments. Looks like URL tests are missing
| // "xpack.rollup.start_job.json", | ||
| // "xpack.rollup.stop_job.json", | ||
| "xpack.rollup.rollup_search.json", | ||
| //"xpack.rollup.rollup_search.json", |
| public IndexingJobState JobState { get; internal set; } | ||
|
|
||
| [JsonProperty("current_position")] | ||
| public IDictionary<string, object> CurrentPosition { get; internal set; } |
Contributor
There was a problem hiding this comment.
Should this be IReadOnlyDictionary<string, object>, and possibly initialized?
| { | ||
| public partial interface IElasticClient | ||
| { | ||
| /// <inheritdoc/> |
Contributor
There was a problem hiding this comment.
I think this should have a <summary>...</summary> and all other overloads inheritdoc from it
|
|
||
| var si = Sanitize(RandomInitializer); | ||
| dict.Add(Integration.ClientMethod.Initializer, request(si, client, initializerBody(si))); | ||
| var si = this.Sanitize(RandomInitializer); |
Contributor
There was a problem hiding this comment.
I think we ought to pass across the codebase for 7.x and standardize the conventions 😄
| AggregationDictionary IRollupSearchRequest.Aggregations { get; set; } | ||
| int? IRollupSearchRequest.Size { get; set; } | ||
|
|
||
| /// <summary>When doing rollup searches against rolled up and live indices size needs to be set to 0 explicitly </summary> |
Contributor
There was a problem hiding this comment.
Move the XML comments to the interface and <inheritdoc />
russcam
approved these changes
Oct 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pending #3448