rollup job crud apis #3448
rollup job crud apis #3448
Conversation
russcam
left a comment
russcam
left a comment
There was a problem hiding this comment.
Generally LGTM; left some comments regarding documentation
| [JsonProperty("index_pattern")] | ||
| public string IndexPattern { get; internal set; } | ||
|
|
||
| /// <inheritdoc cref="ICreateRollupJobRequest.RollupIndex"> |
There was a problem hiding this comment.
<inheritdoc /> needs to be self-closing
| [JsonProperty("rollup_index")] | ||
| public IndexName RollupIndex { get; internal set; } | ||
|
|
||
| /// <inheritdoc cref="ICreateRollupJobRequest.Cron"> |
There was a problem hiding this comment.
<inheritdoc /> needs to be self-closing
| [JsonProperty("cron")] | ||
| public string Cron { get; internal set; } | ||
|
|
||
| /// <inheritdoc cref="ICreateRollupJobRequest.PageSize"> |
There was a problem hiding this comment.
<inheritdoc /> needs to be self-closing
| [JsonProperty("page_size")] | ||
| public long? PageSize { get; internal set; } | ||
|
|
||
| /// <inheritdoc cref="ICreateRollupJobRequest.Groups"> |
There was a problem hiding this comment.
<inheritdoc /> needs to be self-closing
| // "xpack.rollup.get_jobs.json", | ||
| // "xpack.rollup.put_job.json", | ||
| // "xpack.rollup.start_job.json", | ||
| // "xpack.rollup.stop_job.json", |
| { | ||
| public partial interface IElasticClient | ||
| { | ||
| /// <inheritdoc/> |
There was a problem hiding this comment.
I think this should have a <summary>...</summary> and all other overloads inheritdoc from it
| { | ||
| public partial interface IElasticClient | ||
| { | ||
| /// <inheritdoc/> |
There was a problem hiding this comment.
I think this should have a <summary>...</summary> and all other overloads inheritdoc from it
| { | ||
| public partial interface IElasticClient | ||
| { | ||
| /// <inheritdoc/> |
There was a problem hiding this comment.
I think this should have a <summary>...</summary> and all other overloads inheritdoc from it
This commit adds support for the Rollup APIs: - CreateRollupJob - GetRollupJob - DeleteRollupJob - StartRollupJob - StopRollupJob - GetRollupCapabilities - RollupSearch (cherry picked from commit 4cb05c0)
This adds support for the rollup job crud API's
As well as: