Assign instance to Aggregations property #3287
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes a bug with SingleBucketAggregate having an Aggregations property; the property should not be there. Mark as obsolete and assign the instance itself to the property, to at least mitigate null reference exception. Closes #3286
codebrain
approved these changes
Jun 22, 2018
Contributor
codebrain
left a comment
codebrain
left a comment
There was a problem hiding this comment.
LGTM - one comment on text change.
| #pragma warning restore 618 | ||
| } | ||
|
|
||
| [Obsolete("Use methods on instance itself. Will be removed in NEST 7.x")] |
Contributor
There was a problem hiding this comment.
Use methods on this instance...
Contributor
Author
|
Removed in master: bc8f4fb |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes a bug with SingleBucketAggregate having an Aggregations
property; the property should not be there. Mark as obsolete and assign the
instance itself to the property, to at least mitigate null reference exception.
Remove
Aggregationswhen porting to masterCloses #3286