Assert all collections on Response types are read only #2405
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
opened PR for |
Reflection unit test traverses IResponse properties to check their types. Add Fluent Assertions for IReadOnlyDictionary<TKey, TValue>. See https://github.com/dennisdoomen/FluentAssertions/issues/357 Update Watcher APIs to use readonly collections Use Actions for actions on Watch type Enable readonly collection deserialization in SimpleJson
russcam
force-pushed
the
fix/master-readonly-collections
branch
from
73a77a2 to
010ee2b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following on from merge of #2399 into
master.Should we also assert that
IReadOnlyCollection<T>andIReadOnlyDictionary<TKey, TValue>properties on responses are notnullas a general rule?