Remove IDictionary from IIsADictionary<TKey,TValue> definition #2399
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mpdreamz
approved these changes
Nov 21, 2016
| public IIndexField IndexField { get; set; } | ||
| /// <inheritdoc/> | ||
| public FluentDictionary<string, object> Meta { get; set; } | ||
| public IDictionary<string, object> Meta { get; set; } |
Member
There was a problem hiding this comment.
ooemf we had a fluent dictionary as a property 😢
| var properties = new Properties(); | ||
| var autoProperties = new PropertyWalker(typeof(T), visitor, maxRecursion).GetProperties(); | ||
| foreach (var autoProperty in (IEnumerable<KeyValuePair<PropertyName, IProperty>>)autoProperties) | ||
| foreach (var autoProperty in autoProperties) |
russcam
force-pushed
the
fix/master-remove-idictionary
branch
from
3f33bd3 to
b062c5e
Compare
Contributor
Author
|
ported to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes any ambiguity when enumerating the items in an instance of
IIsADictionary<TKey,TValue>.Any implementation of
IIsADictionary<TKey, TValue>must always provide implementations for the contract ofIDictionary<TKey, TValue>so there is little value in having theIDictionarycontract where boxing and unboxing will be incurred, except to distinguish types that implementIDictionarythat are notIIsADictionary.Removes the cost boxing of values in
VerbatimDictionaryKeysConverterby havingTKeyandTValuegeneric type parameters.