fix: update ids to correct v2 api format #584
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All the new id's are hex encoded random numbers. Their sizes are: - error id: 128 bit - transaction id: 64 bit - span id: 64 bit - trace id: 128 bit The implemented id generator is temporary (except error id's) and will be replaced by the OpenTracing id engine once that lands.
This was referenced Sep 14, 2018
Qard
approved these changes
Sep 14, 2018
Qard
suggested changes
Sep 14, 2018
watson
added a commit
that referenced
this pull request
Oct 19, 2018
All the new id's are hex encoded random numbers. Their sizes are: - error id: 128 bit - transaction id: 64 bit - span id: 64 bit - trace id: 128 bit The implemented id generator is temporary (except error id's) and will be replaced by the OpenTracing id engine once that lands.
watson
added a commit
to watson/apm-agent-nodejs
that referenced
this pull request
Oct 27, 2018
All the new id's are hex encoded random numbers. Their sizes are: - error id: 128 bit - transaction id: 64 bit - span id: 64 bit - trace id: 128 bit The implemented id generator is temporary (except error id's) and will be replaced by the OpenTracing id engine once that lands.
Qard
pushed a commit
that referenced
this pull request
Oct 31, 2018
All the new id's are hex encoded random numbers. Their sizes are: - error id: 128 bit - transaction id: 64 bit - span id: 64 bit - trace id: 128 bit The implemented id generator is temporary (except error id's) and will be replaced by the OpenTracing id engine once that lands.
watson
added a commit
to watson/apm-agent-nodejs
that referenced
this pull request
Nov 6, 2018
All the new id's are hex encoded random numbers. Their sizes are: - error id: 128 bit - transaction id: 64 bit - span id: 64 bit - trace id: 128 bit The implemented id generator is temporary (except error id's) and will be replaced by the OpenTracing id engine once that lands.
watson
added a commit
that referenced
this pull request
Nov 6, 2018
All the new id's are hex encoded random numbers. Their sizes are: - error id: 128 bit - transaction id: 64 bit - span id: 64 bit - trace id: 128 bit The implemented id generator is temporary (except error id's) and will be replaced by the OpenTracing id engine once that lands.
Qard
pushed a commit
that referenced
this pull request
Nov 8, 2018
All the new id's are hex encoded random numbers. Their sizes are: - error id: 128 bit - transaction id: 64 bit - span id: 64 bit - trace id: 128 bit The implemented id generator is temporary (except error id's) and will be replaced by the OpenTracing id engine once that lands.
watson
added a commit
that referenced
this pull request
Nov 10, 2018
All the new id's are hex encoded random numbers. Their sizes are: - error id: 128 bit - transaction id: 64 bit - span id: 64 bit - trace id: 128 bit The implemented id generator is temporary (except error id's) and will be replaced by the OpenTracing id engine once that lands.
watson
added a commit
to watson/apm-agent-nodejs
that referenced
this pull request
Nov 13, 2018
All the new id's are hex encoded random numbers. Their sizes are: - error id: 128 bit - transaction id: 64 bit - span id: 64 bit - trace id: 128 bit The implemented id generator is temporary (except error id's) and will be replaced by the OpenTracing id engine once that lands.
watson
added a commit
to watson/apm-agent-nodejs
that referenced
this pull request
Nov 13, 2018
All the new id's are hex encoded random numbers. Their sizes are: - error id: 128 bit - transaction id: 64 bit - span id: 64 bit - trace id: 128 bit The implemented id generator is temporary (except error id's) and will be replaced by the OpenTracing id engine once that lands.
watson
added a commit
to watson/apm-agent-nodejs
that referenced
this pull request
Nov 13, 2018
All the new id's are hex encoded random numbers. Their sizes are: - error id: 128 bit - transaction id: 64 bit - span id: 64 bit - trace id: 128 bit The implemented id generator is temporary (except error id's) and will be replaced by the OpenTracing id engine once that lands.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All the new id's are hex encoded random numbers. Their sizes are:
The implemented id generator is temporary (except error id's) and will be replaced by the OpenTracing id engine once that lands.
Checklist