Skip to content

Conversation

@pull
Copy link

@pull pull bot commented Apr 19, 2022

See Commits and Changes for more details.


Created by pull[bot]

Can you help keep this open source service alive? 💖 Please sponsor : )

david-perez and others added 2 commits April 19, 2022 17:56
This is the result of running `ktlint` from the repository root. We have
`ktlint` running on pre-commit and CI on changed files, but these
violations slipped through the cracks.
To support these new protocols, we also changed the runtime Router definition as for both awsJson 1.0 and 1.1, every request MUST be sent to the root URL (/) using the HTTP "POST" method.

The runtime Router now supports explicitly all the available protocols.

There are still some protocol tests failing for awsJson 1.0 and 1.1. The failure are caused by the missing implementation of @endpoint trait and date parsing. Protocol tests for these 2 protocols are heavily biased towards Responses. Before announcing support for awsJson 1.0 and 1.1, we should increase the protocol tests coverage.

Signed-off-by: Bigo <[email protected]>
Co-authored-by: david-perez <[email protected]>
@pull pull bot added the ⤵️ pull label Apr 19, 2022
jdisanti and others added 8 commits April 21, 2022 09:22
* Upgrade to Smithy 1.16.2

* Remove extra test fixed in Smithy 1.16.2

* Upgrade to Smithy 1.16.3

* Remove extra test fixed in Smithy 1.16.3

* Remove failing expectation from server tests

* Upgrade to Smithy 1.17.0

* Upgrade to Smithy 1.18.1

* Upgrade to Smithy 1.19.0

* Upgrade to Smithy 1.21.0

* Update changelog

* Fix Gradle repositories
In #1268, runtime crates were updated to Rust 2021 edition.

Co-authored-by: Russell Cohen <[email protected]>
…eam from a file (#1238)

* Allow to specify a read buffer initial capacity when creating ByteStream from a file

The behaviour of the existing ByteStream::from_file / ByteStream::from_path is unchanged (using a default buffer capacity of 4k, which corresponds to Tokio's ReaderStream default buffer capacity). Using higher buffer sizes can result in a large reduction in CPU during S3 uploads, at the cost of memory increase.

* Rename len to file_size

This makes the distinction with the buffer size clearer

* Use a builder to specify advanced options to create a ByteStream

* Improved comments

* Specify the unit to use for PathBodyBuilder.with_file_size

* Improved comments following review

* Rename PathBodyBuilder to FsBuilder

* Renaming in FsBuilder

- renames `with_buffer_size` to `buffer_size`
- renames `with_file_size` to `file_size`
- renames `byte_stream` to `build`

* Make PathBody private

* Updated API for FsBuilder

* Document panic behavior of ByteStream::build

* Document ByteStream::read_from

* Move ByteStream::read_from

No functional change

* Update rust-runtime/aws-smithy-http/src/byte_stream.rs

a -> an

Co-authored-by: Russell Cohen <[email protected]>
Co-authored-by: Russell Cohen <[email protected]>
* add: callback trait proposed in rfc#0012
add: callback setting API to ByteStream
add: callback setting API to SdkBody
add: callback tests for streaming and buffered data
add: private callback fns for calculating checksums
udpate: pub methods on private struct `Inner` to be private
update: changelog
remove: Sync bound from SdkBody test "sdk_body_is_send()"
add: fn to merge `HeaderMap`s by appending
add: tests for new functionality

* add: Sync bound to callbacks
refactor: poll_trailers method
update: split out checksum callbacks into their own module
formatting: use throwaway let binding instead of allow unused variable

* add: license file to new crate
add: readme file to new crate

* add: missing anchor to Cargo.toml

* rename: aws-smithy-checksum-callbacks to aws-smithy-checksums
add: two more append_merge_header_maps tests
update: make append_merge_header_maps pub(crate)
remove: check for non-existent log line

* remove: doc test for private fn

* update: checksum callback struct names
This commit upgrades:

* Kotlin to 1.6.20,
* Kotest to 5.2.3,
* Ktlint to 0.45.2; and
* Jacoco to 0.8.8.

Perhaps the only noteworthy change is that Ktlint now has a lint to
detect that the name of a class/object defined solely in a file has to
coincide with the filename.
* Update to remove usages of deprecated writers

* Add Support for "debugMode"

Add a `debugMode` flag. This will render a best-efforts `file:line` number comment for every generated section of code.

* Fix server codegen
@eduardomourar eduardomourar merged commit d60e1a1 into eduardomourar:main Apr 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants